* [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE
@ 2013-11-08 20:25 Uwe Kleine-König
2013-11-13 5:37 ` Haojian Zhuang
2013-11-26 13:37 ` Uwe Kleine-König
0 siblings, 2 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2013-11-08 20:25 UTC (permalink / raw)
To: linux-arm-kernel
The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform
specific header <mach/timex.h>. There are plans to stop using and kill
these platform specific headers. So fix the only user of pxa's
<mach/timex.h> to not use it.
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
It would be nice to use the clk API to find the tick rate, but I didn't
find any clk to use.
---
drivers/rtc/rtc-pxa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
index a355f2b..0ba07e1 100644
--- a/drivers/rtc/rtc-pxa.c
+++ b/drivers/rtc/rtc-pxa.c
@@ -32,7 +32,7 @@
#include <mach/hardware.h>
-#define TIMER_FREQ CLOCK_TICK_RATE
+#define TIMER_FREQ get_clock_tick_rate()
#define RTC_DEF_DIVIDER (32768 - 1)
#define RTC_DEF_TRIM 0
#define MAXFREQ_PERIODIC 1000
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE
2013-11-08 20:25 [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE Uwe Kleine-König
@ 2013-11-13 5:37 ` Haojian Zhuang
2013-11-26 13:37 ` Uwe Kleine-König
1 sibling, 0 replies; 7+ messages in thread
From: Haojian Zhuang @ 2013-11-13 5:37 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Nov 9, 2013 at 4:25 AM, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
> The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform
> specific header <mach/timex.h>. There are plans to stop using and kill
> these platform specific headers. So fix the only user of pxa's
> <mach/timex.h> to not use it.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> It would be nice to use the clk API to find the tick rate, but I didn't
> find any clk to use.
> ---
> drivers/rtc/rtc-pxa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
> index a355f2b..0ba07e1 100644
> --- a/drivers/rtc/rtc-pxa.c
> +++ b/drivers/rtc/rtc-pxa.c
> @@ -32,7 +32,7 @@
>
> #include <mach/hardware.h>
>
> -#define TIMER_FREQ CLOCK_TICK_RATE
> +#define TIMER_FREQ get_clock_tick_rate()
> #define RTC_DEF_DIVIDER (32768 - 1)
> #define RTC_DEF_TRIM 0
> #define MAXFREQ_PERIODIC 1000
> --
> 1.7.10.4
>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE
2013-11-08 20:25 [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE Uwe Kleine-König
2013-11-13 5:37 ` Haojian Zhuang
@ 2013-11-26 13:37 ` Uwe Kleine-König
2013-11-27 1:26 ` Haojian Zhuang
1 sibling, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2013-11-26 13:37 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
[Cc: += akpm]
On Fri, Nov 08, 2013 at 09:25:18PM +0100, Uwe Kleine-K?nig wrote:
> The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform
> specific header <mach/timex.h>. There are plans to stop using and kill
> these platform specific headers. So fix the only user of pxa's
> <mach/timex.h> to not use it.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Who is looking for this patch?
Best regards
Uwe
> ---
> It would be nice to use the clk API to find the tick rate, but I didn't
> find any clk to use.
> ---
> drivers/rtc/rtc-pxa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
> index a355f2b..0ba07e1 100644
> --- a/drivers/rtc/rtc-pxa.c
> +++ b/drivers/rtc/rtc-pxa.c
> @@ -32,7 +32,7 @@
>
> #include <mach/hardware.h>
>
> -#define TIMER_FREQ CLOCK_TICK_RATE
> +#define TIMER_FREQ get_clock_tick_rate()
> #define RTC_DEF_DIVIDER (32768 - 1)
> #define RTC_DEF_TRIM 0
> #define MAXFREQ_PERIODIC 1000
> --
> 1.7.10.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE
2013-11-26 13:37 ` Uwe Kleine-König
@ 2013-11-27 1:26 ` Haojian Zhuang
2013-12-07 20:07 ` Robert Jarzmik
0 siblings, 1 reply; 7+ messages in thread
From: Haojian Zhuang @ 2013-11-27 1:26 UTC (permalink / raw)
To: linux-arm-kernel
On 11/26/2013 09:37 PM, Uwe Kleine-K?nig wrote:
> Hello,
>
> [Cc: += akpm]
>
> On Fri, Nov 08, 2013 at 09:25:18PM +0100, Uwe Kleine-K?nig wrote:
>> The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform
>> specific header <mach/timex.h>. There are plans to stop using and kill
>> these platform specific headers. So fix the only user of pxa's
>> <mach/timex.h> to not use it.
>>
>> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Who is looking for this patch?
>
> Best regards
> Uwe
>
>> ---
>> It would be nice to use the clk API to find the tick rate, but I didn't
>> find any clk to use.
>> ---
>> drivers/rtc/rtc-pxa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
>> index a355f2b..0ba07e1 100644
>> --- a/drivers/rtc/rtc-pxa.c
>> +++ b/drivers/rtc/rtc-pxa.c
>> @@ -32,7 +32,7 @@
>>
>> #include <mach/hardware.h>
>>
>> -#define TIMER_FREQ CLOCK_TICK_RATE
>> +#define TIMER_FREQ get_clock_tick_rate()
>> #define RTC_DEF_DIVIDER (32768 - 1)
>> #define RTC_DEF_TRIM 0
>> #define MAXFREQ_PERIODIC 1000
>> --
>> 1.7.10.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
I think that Alessandro could help to merge.
Alessandro,
Is it right?
Regards
Haojian
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE
2013-11-27 1:26 ` Haojian Zhuang
@ 2013-12-07 20:07 ` Robert Jarzmik
2013-12-07 22:30 ` [PATCH v2] rtc: pxa: drop unused #define TIMER_FREQ Uwe Kleine-König
0 siblings, 1 reply; 7+ messages in thread
From: Robert Jarzmik @ 2013-12-07 20:07 UTC (permalink / raw)
To: linux-arm-kernel
Haojian Zhuang <haojian.zhuang@gmail.com> writes:
> On 11/26/2013 09:37 PM, Uwe Kleine-K?nig wrote:
>> Hello,
>>
>> [Cc: += akpm]
>>
>> On Fri, Nov 08, 2013 at 09:25:18PM +0100, Uwe Kleine-K?nig wrote:
>>> The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform
>>> specific header <mach/timex.h>. There are plans to stop using and kill
>>> these platform specific headers. So fix the only user of pxa's
n>>> <mach/timex.h> to not use it.
>>>
>>> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>> Who is looking for this patch?
>>
>> Best regards
>> Uwe
> Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
>
> I think that Alessandro could help to merge.
>
> Alessandro,
> Is it right?
Why won't you just remove TIMER_FREQ all together instead ?
I don't remember why I put that in, but looking back at it, I don't find any
use, so why don't we remove the line ?
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] rtc: pxa: drop unused #define TIMER_FREQ
2013-12-07 20:07 ` Robert Jarzmik
@ 2013-12-07 22:30 ` Uwe Kleine-König
2013-12-08 10:45 ` Robert Jarzmik
0 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2013-12-07 22:30 UTC (permalink / raw)
To: linux-arm-kernel
It seems this symbol was unused since the driver was introduced in
commit dc94436 (rtc: driver for pxa27x and pxa3xx SoC) back in 2009.
As a by-product this patch makes the driver stop "using" the symbol
CLOCK_TICK_RATE which is about to be removed very soon (for ARM).
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
Changes since (implicit) v1, sent with
Message-id:1383942318-12569-1-git-send-email-u.kleine-koenig at pengutronix.de:
- drop define instead of s/CLOCK_TICK_RATE/get_clock_tick_rate()/; thanks to
Robert Jarzmik for pointing that out.
Note I intend to send this patch as part of a series that removes
<mach/timex.h> (and so CLOCK_TICK_RATE) on ARM. So dear maintainer please don't
take this patch but give your blessing that I can take it. (Note, I'm not sure
who's ack I need here; according to MAINTAINERS Alessandro Zummo maintains the
rtc subsystem, but he doesn't seem to be that active for some time and it's
mostly akpm who takes patches.)
drivers/rtc/rtc-pxa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
index a355f2b..cccbf9d 100644
--- a/drivers/rtc/rtc-pxa.c
+++ b/drivers/rtc/rtc-pxa.c
@@ -32,7 +32,6 @@
#include <mach/hardware.h>
-#define TIMER_FREQ CLOCK_TICK_RATE
#define RTC_DEF_DIVIDER (32768 - 1)
#define RTC_DEF_TRIM 0
#define MAXFREQ_PERIODIC 1000
--
1.8.4.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2] rtc: pxa: drop unused #define TIMER_FREQ
2013-12-07 22:30 ` [PATCH v2] rtc: pxa: drop unused #define TIMER_FREQ Uwe Kleine-König
@ 2013-12-08 10:45 ` Robert Jarzmik
0 siblings, 0 replies; 7+ messages in thread
From: Robert Jarzmik @ 2013-12-08 10:45 UTC (permalink / raw)
To: linux-arm-kernel
Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> writes:
> It seems this symbol was unused since the driver was introduced in
> commit dc94436 (rtc: driver for pxa27x and pxa3xx SoC) back in 2009.
>
> As a by-product this patch makes the driver stop "using" the symbol
> CLOCK_TICK_RATE which is about to be removed very soon (for ARM).
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> Changes since (implicit) v1, sent with
> Message-id:1383942318-12569-1-git-send-email-u.kleine-koenig at pengutronix.de:
>
> - drop define instead of s/CLOCK_TICK_RATE/get_clock_tick_rate()/; thanks to
> Robert Jarzmik for pointing that out.
>
> Note I intend to send this patch as part of a series that removes
> <mach/timex.h> (and so CLOCK_TICK_RATE) on ARM. So dear maintainer please don't
> take this patch but give your blessing that I can take it. (Note, I'm not sure
> who's ack I need here; according to MAINTAINERS Alessandro Zummo maintains the
> rtc subsystem, but he doesn't seem to be that active for some time and it's
> mostly akpm who takes patches.)
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
And you're right, Andrew took the last patches to RTC.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-12-08 10:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-08 20:25 [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE Uwe Kleine-König
2013-11-13 5:37 ` Haojian Zhuang
2013-11-26 13:37 ` Uwe Kleine-König
2013-11-27 1:26 ` Haojian Zhuang
2013-12-07 20:07 ` Robert Jarzmik
2013-12-07 22:30 ` [PATCH v2] rtc: pxa: drop unused #define TIMER_FREQ Uwe Kleine-König
2013-12-08 10:45 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).