From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: at91sam9: include <mach/hardware.h> explicitly
Date: Tue, 26 Nov 2013 14:41:17 +0100 [thread overview]
Message-ID: <20131126134117.GF28642@pengutronix.de> (raw)
In-Reply-To: <1384524058-20712-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Fri, Nov 15, 2013 at 03:00:58PM +0100, Uwe Kleine-K?nig wrote:
> The driver needs the symbol AT91_SLOW_CLOCK which is defined in
> arch/arm/mach-at91/include/mach/hardware.h. This file is included
> implicitly via linux/module.h -> linux/kmod.h -> linux/gfp.h ->
> linux/mmzone.h -> linux/memory_hotplug.h -> linux/notifier.h ->
> linux/srcu.h -> linux/workqueue.h -> linux/timer.h -> linux/ktime.h ->
> linux/jiffies.h -> linux/timex.h -> mach/timex.h -> mach/hardware.h .
>
> So better include it explicitly not only because the last link will go
> away soon.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Ping. Is this patch ok despite Jean-Christophe's objection?
Best regards
Uwe
> ---
> drivers/rtc/rtc-at91sam9.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
> index 309b8b3..5963743 100644
> --- a/drivers/rtc/rtc-at91sam9.c
> +++ b/drivers/rtc/rtc-at91sam9.c
> @@ -24,7 +24,7 @@
>
> #include <mach/at91_rtt.h>
> #include <mach/cpu.h>
> -
> +#include <mach/hardware.h>
>
> /*
> * This driver uses two configurable hardware resources that live in the
> --
> 1.8.4.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-11-26 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 14:00 [PATCH] rtc: at91sam9: include <mach/hardware.h> explicitly Uwe Kleine-König
2013-11-15 14:23 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-15 14:55 ` Uwe Kleine-König
2013-11-27 8:49 ` Nicolas Ferre
2013-11-26 13:41 ` Uwe Kleine-König [this message]
2013-11-26 13:44 ` Uwe Kleine-König
2013-11-26 18:36 ` Uwe Kleine-König
2013-12-16 8:11 ` Andrew Morton
2013-12-16 19:28 ` Uwe Kleine-König
2013-12-16 22:46 ` Andrew Morton
2013-12-17 8:15 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126134117.GF28642@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).