From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: PCI: mvebu: return NULL instead of ERR_PTR(ret)
Date: Tue, 26 Nov 2013 11:09:30 -0700 [thread overview]
Message-ID: <20131126180930.GC19852@obsidianresearch.com> (raw)
In-Reply-To: <001101ceea68$cb486220$61d92660$%han@samsung.com>
On Tue, Nov 26, 2013 at 02:31:44PM +0900, Jingoo Han wrote:
> Previously, I sent the patch in order to fix sparse warning as below:
> How about this?
>
> static void __iomem *mvebu_pcie_map_registers(struct platform_device *pdev,
> struct device_node *np, struct mvebu_pcie_port *port)
> {
> struct resource regs;
> int ret = 0;
>
> ret = of_address_to_resource(np, 0, ®s);
> if (ret)
> - return ERR_PTR(ret);
> + return (void __iomem *)ERR_PTR(ret);
You should probably ask the sparse folks for guidance 'git grep
iomem.*ERR_PTR' returns nothing, so this isn't an established pattern.
It seems like sparse should know that ERR_PTR functions can work with
any pointer no matter the type? IS_ERR_PTR will have the same problem
with implicitly dropping the iomem tag.
Regards,
Jason
next prev parent reply other threads:[~2013-11-26 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <001001ceb816$5d1aecc0$1750c640$%han@samsung.com>
2013-11-25 20:02 ` PCI: mvebu: return NULL instead of ERR_PTR(ret) Jason Gunthorpe
2013-11-26 5:31 ` Jingoo Han
2013-11-26 12:27 ` Jason Cooper
2013-11-26 18:09 ` Jason Gunthorpe [this message]
2013-11-27 1:59 ` Jingoo Han
2013-11-27 2:17 ` [PATCH] linux/err.h: Provide an ERR_PTR_IO that returns an __iomem pointer Josh Triplett
2013-11-27 2:26 ` PCI: mvebu: return NULL instead of ERR_PTR(ret) Joe Perches
2013-11-27 2:35 ` Josh Triplett
2013-11-27 2:48 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126180930.GC19852@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).