From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] PCI: imx6: Fix link start operation
Date: Tue, 26 Nov 2013 22:25:43 +0100 [thread overview]
Message-ID: <201311262225.43711.marex@denx.de> (raw)
In-Reply-To: <1385500248-6551-6-git-send-email-marex@denx.de>
Dear Marek Vasut,
> This patch first forces the link into Gen1 mode before starting up
> the link and only after the link is up requests the link to start
> negotiating possible Gen2 mode operation. This is because without
> such sequence, some PCIe switches are not detected at all.
[...]
> + /* Make sure link training is finished as well! */
> + if (count)
> + ret = imx6_pcie_wait_for_link(pp);
> + else
> + ret = -EINVAL;
>
> + if (ret) {
> + dev_err(pp->dev, "Failed to bring link up!\n");
> + } else {
> + tmp = readl(pp->dbi_base + 0x80);
> + dev_err(pp->dev, "Link up, Gen=%i\n", (tmp >> 16) & 0xf);
Hm meh, this dev_err() shouldn't be here of course. But I'd be interested if you
people now get stable Gen2 link up properly all the time. Please test. Thanks!
[...]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-11-26 21:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 21:10 [PATCH 1/7] PCI: imx6: Make reset-gpio optional Marek Vasut
2013-11-26 21:10 ` [PATCH 2/7] [RFC] PCI: imx6: remove outbound io/mem ATU region mapping Marek Vasut
2013-11-27 4:30 ` Pratyush Anand
2013-11-27 8:44 ` Marek Vasut
2013-11-28 5:49 ` Jingoo Han
2013-11-28 17:56 ` Marek Vasut
2013-12-04 5:49 ` Richard Zhu
2013-12-04 7:52 ` Marek Vasut
2013-12-05 0:44 ` Richard Zhu
2013-12-05 1:05 ` Richard Zhu
2013-12-05 1:59 ` Marek Vasut
2013-12-03 20:14 ` Tim Harvey
2013-12-04 10:33 ` Pratyush Anand
2013-12-04 18:51 ` Tim Harvey
2013-12-04 22:01 ` Marek Vasut
2013-11-26 21:10 ` [PATCH 3/7] PCI: imx6: Fix waiting for link up Marek Vasut
2013-11-26 21:10 ` [PATCH 4/7] PCI: imx6: Split away the PHY reset Marek Vasut
2013-11-27 16:23 ` Harro Haan
2013-12-02 23:36 ` Marek Vasut
2013-11-26 21:10 ` [PATCH 5/7] PCI: imx6: Split away the link up wait loop Marek Vasut
2013-11-26 21:10 ` [PATCH 6/7] PCI: imx6: Fix link start operation Marek Vasut
2013-11-26 21:25 ` Marek Vasut [this message]
2013-11-26 21:10 ` [PATCH 7/7] ARM: dts: imx6q-sabrelite: Enable PCI express Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311262225.43711.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).