* [PATCH] Versatile LEDs initialise to off state
@ 2013-11-26 19:44 Russell King - ARM Linux
2013-11-26 23:23 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux @ 2013-11-26 19:44 UTC (permalink / raw)
To: linux-arm-kernel
There really is no excuse to turn on all 8 LEDs at boot time, such
that on the Versatile PB/926 we end up with 6 LEDs on continuously
and forever. We're not a christmas decoration!
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
arch/arm/plat-versatile/leds.c | 4 +-
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-versatile/leds.c b/arch/arm/plat-versatile/leds.c
index d2490d00b46c..c74aa5707dab 100644
--- a/arch/arm/plat-versatile/leds.c
+++ b/arch/arm/plat-versatile/leds.c
@@ -73,7 +73,7 @@ static int __init versatile_leds_init(void)
{
int i;
- /* All ON */
- writel(0xff, LEDREG);
+ /* All off */
+ writel(0, LEDREG);
for (i = 0; i < ARRAY_SIZE(versatile_leds); i++) {
struct versatile_led *led;
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] Versatile LEDs initialise to off state
2013-11-26 19:44 [PATCH] Versatile LEDs initialise to off state Russell King - ARM Linux
@ 2013-11-26 23:23 ` Linus Walleij
2013-11-27 14:18 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2013-11-26 23:23 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 26, 2013 at 8:44 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> There really is no excuse to turn on all 8 LEDs at boot time, such
> that on the Versatile PB/926 we end up with 6 LEDs on continuously
> and forever. We're not a christmas decoration!
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Do you want me to queue this patch thru ARM SoC or are you
taking it through your tree?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Versatile LEDs initialise to off state
2013-11-26 23:23 ` Linus Walleij
@ 2013-11-27 14:18 ` Russell King - ARM Linux
0 siblings, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2013-11-27 14:18 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 27, 2013 at 12:23:32AM +0100, Linus Walleij wrote:
> On Tue, Nov 26, 2013 at 8:44 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>
> > There really is no excuse to turn on all 8 LEDs at boot time, such
> > that on the Versatile PB/926 we end up with 6 LEDs on continuously
> > and forever. We're not a christmas decoration!
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Do you want me to queue this patch thru ARM SoC or are you
> taking it through your tree?
I don't mind. If you want to queue it please use rmk+kernel in the
author address, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-27 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-26 19:44 [PATCH] Versatile LEDs initialise to off state Russell King - ARM Linux
2013-11-26 23:23 ` Linus Walleij
2013-11-27 14:18 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).