public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: socfpga: Add clock for smp_twd timer
Date: Wed, 27 Nov 2013 12:52:42 -0800	[thread overview]
Message-ID: <20131127205242.16819.8437@quantum> (raw)
In-Reply-To: <1380656155.13502.10.camel@linux-builds1>

Quoting Dinh Nguyen (2013-10-01 12:35:55)
> On Tue, 2013-10-01 at 14:23 -0500, Rob Herring wrote:
> > On 09/17/2013 11:32 AM, dinguyen at altera.com wrote:
> > > From: Dinh Nguyen <dinguyen@altera.com>
> > > 
> > > Assign a clock for the twd-timer.
> > > 
> > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > Cc: Rob Herring <rob.herring@calxeda.com>
> > > Cc: Pawel Moll <pawel.moll@arm.com>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > CC: linux-arm-kernel at lists.infradead.org
> > > ---
> > >  arch/arm/boot/dts/socfpga.dtsi |    4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > index acd6c3a..e28df94 100644
> > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > @@ -480,11 +480,11 @@
> > >                     clock-names = "biu", "ciu";
> > >             };
> > >  
> > > -           /* Local timer */
> > > -           timer at fffec600 {
> > > +           local-timer at fffec600 {
> > 
> > timer was the right name.
> 
> I'll put it back...
> 
> > 
> > >                     compatible = "arm,cortex-a9-twd-timer";
> > >                     reg = <0xfffec600 0x100>;
> > >                     interrupts = <1 13 0xf04>;
> > > +                   clocks = <&mpu_periph_clk>;
> > 
> > Otherwise, this looks fine and I wouldn't expect much input on a change
> > that doesn't add a new binding.
> > 
> > Acked-by: Rob Herring <rob.herring@calxeda.com>
> 
> Thanks Rob!

Looks good to me too. Can you respin it with the fix for 'timer' and
I'll take it in?

Thanks,
Mike

> 
> Dinh
> > 
> > Rob
> > 
> > >             };
> > >  
> > >             timer0: timer0 at ffc08000 {
> > > 
> > 
> > 
> 
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2013-11-27 20:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17 16:32 [PATCH 1/2] arm: socfpga: Add clock for smp_twd timer dinguyen at altera.com
2013-09-17 16:32 ` [PATCH 2/2] arm: socfpga: Remove socfpga_init_clocks dinguyen at altera.com
2013-10-01 19:15 ` [PATCH 1/2] arm: socfpga: Add clock for smp_twd timer Dinh Nguyen
2013-10-01 19:23 ` Rob Herring
2013-10-01 19:35   ` Dinh Nguyen
2013-11-27 20:52     ` Mike Turquette [this message]
2013-12-02 17:10       ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131127205242.16819.8437@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox