From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ASoC: tegra: use reset framework
Date: Fri, 29 Nov 2013 12:14:46 +0100 [thread overview]
Message-ID: <20131129111444.GL22771@ulmo.nvidia.com> (raw)
In-Reply-To: <1385496767-8307-1-git-send-email-swarren@wwwdotorg.org>
On Tue, Nov 26, 2013 at 01:12:47PM -0700, Stephen Warren wrote:
[...]
> + rst = reset_control_get(&pdev->dev,
> + configlink_mods[i].rst_name);
> + if (IS_ERR(rst)) {
> + dev_err(&pdev->dev, "Can't get reset %s\n",
> + configlink_mods[i].rst_name);
> + ret = PTR_ERR(rst);
> goto err;
In case where this fails, there's no way to re-assert the resets that
have already been deasserted. That's not an issue introduced by this
patch, though, and perhaps something we may not want to care about at
all, so:
Reviewed-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131129/38f6f464/attachment.sig>
prev parent reply other threads:[~2013-11-29 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 20:12 [PATCH V2] ASoC: tegra: use reset framework Stephen Warren
2013-11-27 17:14 ` Mark Brown
2013-11-29 11:14 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129111444.GL22771@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).