From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sunxi: stop timer from ticking before enabling interrupts
Date: Sat, 30 Nov 2013 15:15:58 +0100 [thread overview]
Message-ID: <20131130141558.GD3002@lukather> (raw)
In-Reply-To: <1385815995-15145-1-git-send-email-marc.zyngier@arm.com>
Hi Marc,
On Sat, Nov 30, 2013 at 12:53:15PM +0000, Marc Zyngier wrote:
> The sun4i timer can still be ticking when we enable the interrupt.
> If another timer is actually used (A7 architected timer, for example),
> odds are that the interrupt will eventually fire with the event_handler
> pointer being NULL.
>
> The obvious fix it to stop the timer before registering the interrupt.
>
> Observed and tested on sun7i (cubietruck).
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
You can add my Acked-by, but you should rather send this to Daniel
Lezcano, which is the clocksource/clockevent maintainer.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131130/af58cd59/attachment.sig>
next prev parent reply other threads:[~2013-11-30 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 12:53 [PATCH] ARM: sunxi: stop timer from ticking before enabling interrupts Marc Zyngier
2013-11-30 14:15 ` Maxime Ripard [this message]
2013-11-30 14:41 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131130141558.GD3002@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).