[PATCH] ARM:INTEGRATOR: Default enable ARM_PATCH_PHYS_VIRT, AUTO_ZRELADDR

[PATCH] ARM:INTEGRATOR: Default enable ARM_PATCH_PHYS_VIRT, AUTO_ZRELADDR

[panchaxari]

ARM_PATCH_PHYS_VIRT and AUTO_ZRELADDR has been enabled as default configs
to integrator platform.

Introduction of PHYS_VIRT config as default would enable phy-to-virt and
virt-to-phy translation function at boot and module loading time
and enforce dynamic reallocation of memory. AUTO_ZRELADDR config would
enable calculation of kernel load address at run time.

PHYS_VIRT config is mutually exclusive to XIP_KERNEL, XIP_KERNEL is used in
systems with NOR flash devices, and ZRELADDR config is mutually exclusive
to ZBOOT_ROM.

Requesting maintainers of Integrator platform to evaluate the changes on the
board and comment, as I dont have the board for testing and also requesting
an ACK.

Signed-off-by: panchaxari <panchaxari.prasannamurthy@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Michal Simek <monstr@monstr.eu>
Cc: Olof Johansson <olof@lixom.net>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
 arch/arm/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 28d84f3..79ba1a8 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -313,6 +313,8 @@ config ARCH_INTEGRATOR
 	bool "ARM Ltd. Integrator family"
 	select ARCH_HAS_CPUFREQ
 	select ARM_AMBA
+	select ARM_PATCH_PHYS_VIRT
+	select AUTO_ZRELADDR
 	select COMMON_CLK
 	select COMMON_CLK_VERSATILE
 	select GENERIC_CLOCKEVENTS
-- 
1.7.10.4

[PATCH] ARM:INTEGRATOR: Default enable ARM_PATCH_PHYS_VIRT, AUTO_ZRELADDR

[Russell King - ARM Linux]

On Mon, Dec 02, 2013 at 04:58:51PM +0530, panchaxari wrote:
> ARM_PATCH_PHYS_VIRT and AUTO_ZRELADDR has been enabled as default configs
> to integrator platform.
> 
> Introduction of PHYS_VIRT config as default would enable phy-to-virt and
> virt-to-phy translation function at boot and module loading time
> and enforce dynamic reallocation of memory. AUTO_ZRELADDR config would
> enable calculation of kernel load address at run time.
> 
> PHYS_VIRT config is mutually exclusive to XIP_KERNEL, XIP_KERNEL is used in
> systems with NOR flash devices, and ZRELADDR config is mutually exclusive
> to ZBOOT_ROM.
> 
> Requesting maintainers of Integrator platform to evaluate the changes on the
> board and comment, as I dont have the board for testing and also requesting
> an ACK.

This is _exactly_ the kind of patches I don't want to see - people
running around changing platforms with no way to test them.  I spent
most of last week sorting out the fallout from the "single zImage"
project breaking the Versatile and footbridge platforms, and I've
decided that this kind of thing has to stop.

We can't have arch/arm living in a constant cycle of total brokenness
with nothing being stable.  It was a hell of a lot better in terms of
not being broken when we didn't have this silly single zImage project.

If you want to do such work, send the patches with "[CFT]" in the
subject line - call for testing.

What that means is "this patch is experimental, we don't know if it
works, and we'd like someone to test it." and more importantly "It's
not for merging yet."

If no one steps up to test it, then it should *not* be merged, because
you're potentially de-stablising an existing platform.  Yes, I know
that will make things harder to get into the kernel, but that's the way
it _should_ be if you're going to be causing pain to people.

Frankly, I suspect most "users" just don't touch the mainline kernel
anymore - they all rely on (eg) debian people to maintain an effective
forked mainline kernel separately which has all our fsckups fixed.
Hence why we don't get to hear about this stuff breaking.

[PATCH] ARM:INTEGRATOR: Default enable ARM_PATCH_PHYS_VIRT, AUTO_ZRELADDR

[Linus Walleij]

On Mon, Dec 2, 2013 at 12:46 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Dec 02, 2013 at 04:58:51PM +0530, panchaxari wrote:
>>
>> Requesting maintainers of Integrator platform to evaluate the changes on the
>> board and comment, as I dont have the board for testing and also requesting
>> an ACK.
>
> This is _exactly_ the kind of patches I don't want to see - people
> running around changing platforms with no way to test them.

Actually, blame me for this. I asked Pancham to send the patch
to the mail list so I would be able to pick it and test it ... I guess
it would have been less confusing if I had just taken the patch
in private and tested it and then sent it out instead...

> If you want to do such work, send the patches with "[CFT]" in the
> subject line - call for testing.

Good point, I've also seen "[RFT]" (request for testing) in some
cases.

Anyway, I'll just go test this thing now and see if it works as
intended.

Yours,
Linus Walleij

[PATCH] ARM:INTEGRATOR: Default enable ARM_PATCH_PHYS_VIRT, AUTO_ZRELADDR

[Russell King - ARM Linux]

On Mon, Dec 02, 2013 at 01:57:10PM +0100, Linus Walleij wrote:
> Good point, I've also seen "[RFT]" (request for testing) in some
> cases.

Note that it still needs [PATCH] before it.  A good way to integrate it
is to use the form "[PATCH CFT n/nn]" where n/nn exists if you have a
series.

[PATCH] ARM:INTEGRATOR: Default enable ARM_PATCH_PHYS_VIRT, AUTO_ZRELADDR

[Linus Walleij]

On Mon, Dec 2, 2013 at 12:28 PM, panchaxari
<panchaxari.prasannamurthy@linaro.org> wrote:

> ARM_PATCH_PHYS_VIRT and AUTO_ZRELADDR has been enabled as default configs
> to integrator platform.

I have tested this now on Integrator/AP and Integrator/CP and it works
fine, so I'm queueing this for v3.14.

Yours,
Linus Walleij