linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: imx6q-udoo: Add USB host support
Date: Mon, 2 Dec 2013 11:53:03 +0000	[thread overview]
Message-ID: <20131202115303.GH12952@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1384394987-15134-2-git-send-email-festevam@gmail.com>

On Thu, Nov 14, 2013 at 02:09:47AM +0000, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Udoo board has USBH1 port connected to a USB2514 hub.
> 
> Add support for it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/boot/dts/imx6q-udoo.dts | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6q-udoo.dts b/arch/arm/boot/dts/imx6q-udoo.dts
> index 1c7f7a1..109b997 100644
> --- a/arch/arm/boot/dts/imx6q-udoo.dts
> +++ b/arch/arm/boot/dts/imx6q-udoo.dts
> @@ -19,6 +19,23 @@
>  	memory {
>  		reg = <0x10000000 0x40000000>;
>  	};
> +
> +	regulators {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +

This should have a ranges property, or it's not a simple-bus.

Why do you even need this anyway? The regulators can live under the root
quite happily.

Thanks,
Mark.

  reply	other threads:[~2013-12-02 11:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14  2:09 [PATCH 1/2] chipidea: ci_hdrc_imx: Allow handling the clock for an USB phy/hub Fabio Estevam
2013-11-14  2:09 ` [PATCH 2/2] ARM: dts: imx6q-udoo: Add USB host support Fabio Estevam
2013-12-02 11:53   ` Mark Rutland [this message]
2013-12-03  7:17     ` Shawn Guo
2013-11-14  3:24 ` [PATCH 1/2] chipidea: ci_hdrc_imx: Allow handling the clock for an USB phy/hub Shawn Guo
2013-11-14  9:56 ` Russell King - ARM Linux
2013-11-14 10:48   ` Fabio Estevam
2013-12-02 11:51 ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131202115303.GH12952@e106331-lin.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).