linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] drm: Add LCD display clock polarity flags
Date: Mon, 2 Dec 2013 20:01:17 +0000	[thread overview]
Message-ID: <20131202200117.GN16735@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1385998768-23512-1-git-send-email-marex@denx.de>

On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote:
> Add DRM flags for the LCD display clock polarity so the pixelclk-active DT
> property can be properly handled by drivers using the DRM API.

I still say that not even this should be part of the DRM mode API to
userspace.  The hint that you're changing the user API is that you're
modifying a header file below a 'uapi' directory.

The settings of double scan, sync polarity etc are all part of the
display mode specification (check CEA-861 documents).  Things like
pixel clock polarity are not part of the mode specification, they're
a property of the display itself and are independent of the mode.

Therefore, they should not be part of struct drm_mode_modeinfo.

  parent reply	other threads:[~2013-12-02 20:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 15:39 [PATCH 1/3] drm: Add LCD display clock polarity flags Marek Vasut
2013-12-02 15:39 ` [PATCH 2/3] imx-drm: ipuv3-crtc: Make DISP_CLK polarity configurable Marek Vasut
2013-12-02 15:39 ` [PATCH 3/3] ARM: dts: imx53: Switch DISP_CLK polarity on M53EVK Marek Vasut
2013-12-02 20:01 ` Russell King - ARM Linux [this message]
2013-12-02 20:32   ` [PATCH 1/3] drm: Add LCD display clock polarity flags Rob Clark
2013-12-03  8:51     ` Ville Syrjälä
2013-12-02 23:42   ` Marek Vasut
2013-12-03 11:44 ` Shawn Guo
2013-12-03 12:07   ` Russell King - ARM Linux
2013-12-09 10:55   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131202200117.GN16735@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).