From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/4] AArch64: KGDB: Add Basic KGDB support
Date: Tue, 3 Dec 2013 11:21:39 +0000 [thread overview]
Message-ID: <20131203112139.GC1169@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20131203101637.GA7552@e106331-lin.cambridge.arm.com>
On Tue, Dec 03, 2013 at 10:16:37AM +0000, Mark Rutland wrote:
> I think that there's a slight problem with this on BE systems.
[...]
> On Sat, Nov 30, 2013 at 06:32:26AM +0000, vijay.kilari at gmail.com wrote:
> > + { "pstate", 4, offsetof(struct pt_regs, pstate)},
>
> As pt_regs::pstate is a u64, we're only describing half of the field
> here (to match GDB's expectations). While we happen to get the half
> we're interested in on an LE system, on a BE system this will point at
> the zeroed half.
Yup, I think you're right. It's almost as if this hasn't been tested on a BE
system.
Given that a large proportion of this CC list *do* actually care about BE,
I'd like to see a tested-by from one of them before this gets merged. I'm
pretty sure GDB has a testsuite which might be of some use.
Will
next prev parent reply other threads:[~2013-12-03 11:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 6:32 [PATCH v5 0/4] AArch64: KGDB support vijay.kilari at gmail.com
2013-11-30 6:32 ` [PATCH v5 1/4] arm64: support single-step and breakpoint handler hooks vijay.kilari at gmail.com
2013-12-03 6:09 ` Sandeepa Prabhu
2013-12-03 11:18 ` Will Deacon
2013-11-30 6:32 ` [PATCH v5 2/4] AArch64: KGDB: Add Basic KGDB support vijay.kilari at gmail.com
2013-12-03 10:16 ` Mark Rutland
2013-12-03 11:21 ` Will Deacon [this message]
2013-12-03 13:38 ` Will Deacon
2013-12-04 5:59 ` Vijay Kilari
2013-12-19 10:08 ` Vijay Kilari
2013-11-30 6:32 ` [PATCH v5 3/4] AArch64: KGDB: Add step debugging support vijay.kilari at gmail.com
2013-11-30 6:32 ` [PATCH v5 4/4] KGDB: make kgdb_breakpoint() as noinline vijay.kilari at gmail.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203112139.GC1169@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).