linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: Add a virtio disk to the RTSM motherboard
Date: Tue, 3 Dec 2013 19:41:43 +0000	[thread overview]
Message-ID: <20131203194136.GB22668@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1386098643-30784-1-git-send-email-broonie@kernel.org>

On Tue, Dec 03, 2013 at 07:24:03PM +0000, Mark Brown wrote:
> From: Mark Hambleton <mahamble@broadcom.com>
> 
> Describe the virtio device so we can mount disk images in the simulator.
> 
> Signed-off-by: Mark Hambleton <mahamble@broadcom.com>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi
> index b45e5f39f577..4ccd96552b70 100644
> --- a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi
> +++ b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi
> @@ -183,6 +183,12 @@
>  				clocks = <&v2m_oscclk1>, <&v2m_clk24mhz>;
>  				clock-names = "clcdclk", "apb_pclk";
>  			};
> +
> +			virtio_block at 0130000 {
> +				compatible = "virtio,mmio";
> +				reg = <0x130000 0x1000>;

Can we make this 0x200 for the size? That's what kvmtool uses and, from the
virtio-mmio spec, config data from offset 0x100+ is driver-specific. A quick
look at the virtio block driver suggests we only use 31 bytes of that at the
moment, so 4k is really OTT (and doesn't match the page size for 64K page
systems anyway).

With that change:

  Acked-by: Will Deacon <will.deacon@arm.com>

Cheers,

Will

  reply	other threads:[~2013-12-03 19:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 19:24 [PATCH] arm64: dts: Add a virtio disk to the RTSM motherboard Mark Brown
2013-12-03 19:41 ` Will Deacon [this message]
2013-12-03 19:51   ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2013-12-02 16:24 Mark Brown
2013-12-03 11:42 ` Will Deacon
2013-12-03 12:43   ` Mark Brown
2013-12-03 13:14   ` Mark Hambleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131203194136.GB22668@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).