From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: gic_arch_extn (Was: [PATCH v3] irqchip: mmp: add dt support for wakeup)
Date: Thu, 5 Dec 2013 00:52:16 +0000 [thread overview]
Message-ID: <20131205005216.GA4360@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1312042347350.30673@ionos.tec.linutronix.de>
On Thu, Dec 05, 2013 at 01:41:53AM +0100, Thomas Gleixner wrote:
> @all who feel responsible for gic_arch_extn
>
> On Wed, 4 Dec 2013, Thomas Gleixner wrote:
> > I'm going to reply in a separate mail on this, because you have
> > brought this to my attention, but you are not responsible in the first
> > place for this brainfart.
>
> Who came up with that gic_arch_extn concept in the first place?
If you'd spend more time reviewing IRQ patches then maybe you'd catch
this at review time. So please stop your rediculous whinging when
most of the problem is your own lack of time.
If you must know, it was introduced by TI to work around the power
management shortcomings of the architecture mandated GIC. No it doesn't
get called for IPIs, but it damned well needs to be called for normal
IRQs.
At the point it was created, it wasn't clear whether this also applied
to local IRQs. Since I *no* *longer* have visibility of what SoC stuff
is doing with it, of course it's not going to get fixed when a common
pattern emerges.
So... congratulations, you've found something which can be improved,
which has come to light as the code has evolved and a better
understanding of what is required has been discovered.
next prev parent reply other threads:[~2013-12-05 0:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1386159214-31483-1-git-send-email-zhangwm@marvell.com>
[not found] ` <alpine.DEB.2.02.1312042234190.30673@ionos.tec.linutronix.de>
2013-12-05 0:41 ` ARM: gic_arch_extn (Was: [PATCH v3] irqchip: mmp: add dt support for wakeup) Thomas Gleixner
2013-12-05 0:52 ` Russell King - ARM Linux [this message]
2013-12-05 2:12 ` Thomas Gleixner
2013-12-05 9:49 ` Russell King - ARM Linux
2013-12-06 21:25 ` Thomas Gleixner
2013-12-07 0:43 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205005216.GA4360@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).