linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL for-next] ARM: mm: Switch ARM port to NO_BOOTMEM for 3.14
Date: Thu, 5 Dec 2013 10:33:52 +0000	[thread overview]
Message-ID: <20131205103352.GD4360@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1386017539-10295-1-git-send-email-santosh.shilimkar@ti.com>

On Mon, Dec 02, 2013 at 03:52:19PM -0500, Santosh Shilimkar wrote:
> Russell,
> 
> Here is the pull request for-next so that the series gets wider testing
> to catch any regression early in the cycle.

This unfortunately adds a new warning to all the ARM builds:

mm/nobootmem.c: In function '__free_pages_memory':
mm/nobootmem.c:88:201: warning: comparison of distinct pointer types lacks a cast

I don't think it's your change which is causing this, but it does
introduce this new code.  The problem is this:

        while (start < end) {
                order = min(MAX_ORDER - 1UL, __ffs(start));

The types of "MAX_ORDER - 1UL" and "__ffs(start)" differ, which may leads
to min() having unexpected behaviour.  This isn't helped by:

arch/x86/include/asm/bitops.h:static inline unsigned long __ffs(unsigned long word)

vs

static inline int fls(int x)
...
#define ffs(x) ({ unsigned long __t = (x); fls(__t & -__t); })
#define __ffs(x) (ffs(x) - 1)

So on ARM, we have a different return type.  We need to fix ARM's
definition of __ffs() et.al. to have comparable return types to x86.

  reply	other threads:[~2013-12-05 10:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 20:52 [GIT PULL for-next] ARM: mm: Switch ARM port to NO_BOOTMEM for 3.14 Santosh Shilimkar
2013-12-05 10:33 ` Russell King - ARM Linux [this message]
2013-12-05 12:28   ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131205103352.GD4360@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).