From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: nand: pxa3xx: Disable "armada370-nand" compatible support
Date: Sat, 7 Dec 2013 22:35:26 -0300 [thread overview]
Message-ID: <20131208013525.GA4487@localhost> (raw)
In-Reply-To: <20131207232315.GC11251@titan.lakedaemon.net>
On Sat, Dec 07, 2013 at 06:23:15PM -0500, Jason Cooper wrote:
> > +/*
> > + * Currently, the armada370 support is incomplete and can cause the
> > + * system to crash. Disable it until all the infrastructure is in place.
> > + */
> > +#if 0
> > {
> > .compatible = "marvell,armada370-nand",
> > .data = (void *)PXA3XX_NAND_VARIANT_ARMADA370,
> > },
> > +#endif
>
> I prefer to just remove the lines.
>
I'm actually fine either way. Did both (disable and remove) but since all
the code is already sitting and waiting for v3.14 thought it might be cleaner
to just "disable" it.
Brian (given you're going to take the patch): what do you think?
If we agree to remove the lines, shall we also revert the binding
documentation, removing the compatible from there as well?
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-08 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 15:39 [PATCH] mtd: nand: pxa3xx: Disable "armada370-nand" compatible support Ezequiel Garcia
2013-12-07 23:23 ` Jason Cooper
2013-12-08 1:35 ` Ezequiel Garcia [this message]
2013-12-08 1:40 ` Jason Cooper
2013-12-09 20:46 ` Brian Norris
2013-12-09 21:08 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131208013525.GA4487@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).