From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation
Date: Mon, 9 Dec 2013 09:37:48 +0000 [thread overview]
Message-ID: <20131209093748.GA12675@lee--X1> (raw)
In-Reply-To: <20131208190739.GA18977@saruman.home>
> > The code looks mostly fine, but the implementation of the commit logs
> > seems lazy. Please submit a v3 using coherent sentences with full
> > explanations and correct punctuation.
>
> example ?
All of your commit messages.
> that macro just helps removing some extra
^- Sentences start with an uppercase character.
> line of code and hides ffs() calls.
>
> while at that, also fix a variable shadowing
^- Sentences start with an uppercase character.
> bug where 'int irq' was being redeclared inside
> inner loop while it was also argument to interrupt
> handler.
< --------------- 50 chars ----------------- >
Please use the full 72 char (or there abouts) width of the buffer.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-12-09 9:37 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 3:42 [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 02/15] mfd: menelaus: Switch over to module_i2c_driver Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 03/15] mfd: menelaus: Convert to threaded irq Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 04/15] mfd: menelaus: Remove unnecessary loop Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 05/15] mfd: menelaus: Use for_each_set_bit() Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 06/15] mfd: menelaus: Pass menelaus pointer as argument to enable/disable irq Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 07/15] mfd: menelaus: Limit the usage of the_menelaus Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 09/15] mfd: menelaus: Pass menelaus_chip pointer to get/set voltage Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 10/15] mfd: menelaus: Pass menelaus_chip argument to menelaus <-> time helpers Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 11/15] mfd: menelaus: Start to use irqdomain Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 12/15] mfd: menelaus: Switch all children to threaded_irq Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 13/15] mfd: menelaus: Remove unnecessary definition Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 14/15] mfd: menelaus: IRQ is a requirement Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 15/15] mfd: menelaus: Use devm_request_threaded_irq() Felipe Balbi
2013-12-03 9:51 ` [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation Lee Jones
2013-12-03 9:53 ` Lee Jones
2013-12-08 19:07 ` Felipe Balbi
2013-12-09 9:37 ` Lee Jones [this message]
2013-12-09 16:14 ` Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 " Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 02/15] mfd: menelaus: Switch over to module_i2c_driver Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 03/15] mfd: menelaus: Convert to threaded irq Felipe Balbi
2013-12-10 9:32 ` Lee Jones
2013-12-10 16:31 ` Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 04/15] mfd: menelaus: Remove unnecessary loop Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 05/15] mfd: menelaus: Use for_each_set_bit() Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 06/15] mfd: menelaus: Pass menelaus pointer as argument to enable/disable irq Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 07/15] mfd: menelaus: Limit the usage of the_menelaus Felipe Balbi
2013-12-10 8:57 ` Lee Jones
2013-12-10 16:32 ` Felipe Balbi
2013-12-11 9:17 ` Lee Jones
2013-12-09 16:21 ` [PATCH v3 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions Felipe Balbi
2013-12-10 9:00 ` Lee Jones
2013-12-10 16:32 ` Felipe Balbi
2013-12-10 18:42 ` Lee Jones
2013-12-09 16:21 ` [PATCH v3 09/15] mfd: menelaus: Pass menelaus_chip pointer to get/set voltage Felipe Balbi
2013-12-10 9:01 ` Lee Jones
2013-12-09 16:21 ` [PATCH v3 10/15] mfd: menelaus: Pass menelaus_chip argument to menelaus <-> time helpers Felipe Balbi
2013-12-10 9:02 ` Lee Jones
2013-12-09 16:21 ` [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain Felipe Balbi
2013-12-10 9:20 ` Lee Jones
2013-12-10 16:34 ` Felipe Balbi
2013-12-10 18:37 ` Lee Jones
2013-12-10 18:46 ` Tony Lindgren
2013-12-11 9:06 ` Lee Jones
2013-12-09 16:21 ` [PATCH v3 12/15] mfd: menelaus: Switch all children to threaded_irq Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 13/15] mfd: menelaus: Remove unnecessary definition Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 14/15] mfd: menelaus: IRQ is a requirement Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 15/15] mfd: menelaus: Use devm_request_threaded_irq() Felipe Balbi
2013-12-10 9:30 ` Lee Jones
2013-12-10 16:34 ` Felipe Balbi
2013-12-10 18:32 ` Lee Jones
2013-12-11 9:48 ` [PATCH v3 01/15] mfd: menelaus: Drop __exit section annotation Uwe Kleine-König
2013-12-10 8:50 ` [PATCH v2 " Lee Jones
2013-12-10 16:36 ` Felipe Balbi
2013-12-06 13:41 ` Aaro Koskinen
2013-12-11 9:44 ` Uwe Kleine-König
2013-12-16 15:39 ` Lee Jones
2013-12-17 0:08 ` [PATCH 01/10] " Felipe Balbi
2013-12-17 0:08 ` [PATCH 02/10] mfd: menelaus: Switch over to module_i2c_driver Felipe Balbi
2013-12-17 0:08 ` [PATCH 03/10] mfd: menelaus: Convert to threaded irq Felipe Balbi
2013-12-17 0:08 ` [PATCH 04/10] mfd: menelaus: Remove unnecessary loop Felipe Balbi
2013-12-17 0:08 ` [PATCH 05/10] mfd: menelaus: Use for_each_set_bit() Felipe Balbi
2013-12-17 0:17 ` Joe Perches
2013-12-17 0:19 ` Felipe Balbi
2013-12-17 0:08 ` [PATCH 06/10] mfd: menelaus: Limit the usage of the_menelaus Felipe Balbi
2013-12-17 0:08 ` [PATCH 07/10] mfd: menelaus: Start to use irqdomain Felipe Balbi
2013-12-17 10:32 ` Lee Jones
2013-12-17 0:08 ` [PATCH 08/10] mfd: menelaus: Switch all children to threaded_irq Felipe Balbi
2013-12-17 10:35 ` Lee Jones
2013-12-17 0:08 ` [PATCH 09/10] mfd: menelaus: Remove unnecessary definition Felipe Balbi
2013-12-17 0:08 ` [PATCH 10/10] mfd: menelaus: IRQ is a requirement Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209093748.GA12675@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).