From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/6] ARM: at91/dt: define sama5d3 clocks
Date: Mon, 9 Dec 2013 16:48:13 +0100 [thread overview]
Message-ID: <201312091648.13802.arnd@arndb.de> (raw)
In-Reply-To: <52A582AB.6010504@overkiz.com>
On Monday 09 December 2013, boris brezillon wrote:
> > You are adding "clock-names" properties in a lot of cases. Are you sure you
> > are using the strings that are documented in the respective device bindings
> > for each name? In a lot of cases, drivers just want an anonymous clock
> > and we don't name them.
>
> I rechecked it, and almost all drivers call [devm_]clk_get with a
> specific clock
> name, and as a result we must specify the "clock-names" property.
> The only exceptions I found are the spi and PIT (Periodic Interval
> Timer) drivers,
> and "clock-names" property is not defined in these nodes.
Yes, I understood that the *drivers* use the names, but are they actually
documented in the device bindings? If not, it might be better to change the
drivers.
Arnd
next prev parent reply other threads:[~2013-12-09 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 14:49 [PATCH v4 0/6] ARM: at91: use new at91 clks for samad3 SoCs Boris BREZILLON
2013-11-28 14:50 ` [PATCH v4 1/6] ARM: at91: prepare sama5 dt boards transition to common clk Boris BREZILLON
2013-11-28 14:50 ` [PATCH v4 2/6] ARM: at91: prepare common clk transition for sama5d3 SoC Boris BREZILLON
2013-11-28 14:50 ` [PATCH v4 3/6] ARM: at91/dt: define sama5d3 clocks Boris BREZILLON
2013-12-09 2:09 ` Arnd Bergmann
2013-12-09 8:43 ` boris brezillon
2013-12-09 15:48 ` Arnd Bergmann [this message]
2013-12-09 16:17 ` boris brezillon
2013-12-09 16:48 ` Arnd Bergmann
2013-12-09 17:02 ` boris brezillon
2013-12-09 21:05 ` Arnd Bergmann
2013-11-28 14:50 ` [PATCH v4 4/6] ARM: at91/dt: define sama5d3xek's main clk frequency Boris BREZILLON
2013-11-28 14:51 ` [PATCH v4 5/6] ARM: at91: move sama5d3 SoC to common clk Boris BREZILLON
2013-11-28 14:52 ` [PATCH v4 6/6] ARM: at91/dt: remove old clk material Boris BREZILLON
2013-12-02 14:35 ` [PATCH v4 0/6] ARM: at91: use new at91 clks for samad3 SoCs Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312091648.13802.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).