From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] mm/ARM: dma: fix conflicting types for 'arm_dma_zone_size'
Date: Tue, 10 Dec 2013 21:25:23 +0000 [thread overview]
Message-ID: <20131210212523.GE4360@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1386703798-26521-2-git-send-email-santosh.shilimkar@ti.com>
On Tue, Dec 10, 2013 at 02:29:57PM -0500, Santosh Shilimkar wrote:
> diff --git a/arch/arm/include/asm/dma.h b/arch/arm/include/asm/dma.h
> index 58b8c6a..1439b80 100644
> --- a/arch/arm/include/asm/dma.h
> +++ b/arch/arm/include/asm/dma.h
> @@ -8,7 +8,7 @@
> #define MAX_DMA_ADDRESS 0xffffffffUL
> #else
> #define MAX_DMA_ADDRESS ({ \
> - extern unsigned long arm_dma_zone_size; \
> + extern phys_addr_t arm_dma_zone_size; \
> arm_dma_zone_size ? \
> (PAGE_OFFSET + arm_dma_zone_size) : 0xffffffffUL; })
This is wrong. Take a moment to look at it more closely. What does
"PAGE_OFFSET" tell you about what its returning?
What happens if arm_dma_zone_size is greater than 1GB when PAGE_OFFSET
is at the default setting of 3GB?
next prev parent reply other threads:[~2013-12-10 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 19:29 [PATCH 0/2] mm: memblock: Couple of kbuild fixes after the memblock series Santosh Shilimkar
2013-12-10 19:29 ` [PATCH 1/2] mm/ARM: dma: fix conflicting types for 'arm_dma_zone_size' Santosh Shilimkar
2013-12-10 21:25 ` Russell King - ARM Linux [this message]
2013-12-10 19:29 ` [PATCH 2/2] mm/memblock: fix buld of "cris" arch Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210212523.GE4360@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).