public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: add missing break to fuse initialization code
Date: Wed, 11 Dec 2013 17:08:11 -0800	[thread overview]
Message-ID: <20131212010811.GA21856@quad.lixom.net> (raw)
In-Reply-To: <20131206210957.GC1685@mithrandir>

On Fri, Dec 06, 2013 at 10:09:57PM +0100, Thierry Reding wrote:
> On Fri, Dec 06, 2013 at 01:33:50PM -0700, Stephen Warren wrote:
> > From: Stephen Warren <swarren@nvidia.com>
> > 
> > Add a missing break to the switch in tegra_init_fuse() which determines
> > which SoC the code is running on. This prevents the Tegra30+ fuse
> > handling code from running on Tegra20.
> > 
> > Fixes: 3bd1ae57f7bb ("ARM: tegra: add fuses as device randomness")
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > ---
> > This is a fix for 3.13.
> > 
> >  arch/arm/mach-tegra/fuse.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/mach-tegra/fuse.c b/arch/arm/mach-tegra/fuse.c
> > index 9a4e910c3796..13995b0be9d9 100644
> > --- a/arch/arm/mach-tegra/fuse.c
> > +++ b/arch/arm/mach-tegra/fuse.c
> > @@ -198,6 +198,7 @@ void __init tegra_init_fuse(void)
> >  	switch (tegra_chip_id) {
> >  	case TEGRA20:
> >  		tegra20_fuse_init_randomness();
> > +		break;
> >  	case TEGRA30:
> >  	case TEGRA114:
> >  	default:
> 
> The code that follows here also doesn't have a break. While not strictly
> necessary it might be good to have one for consistency. Either way,
> though:
> 
> Reviewed-by: Thierry Reding <treding@nvidia.com>


Applied, thanks.


-Olof

      reply	other threads:[~2013-12-12  1:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 20:33 [PATCH] ARM: tegra: add missing break to fuse initialization code Stephen Warren
2013-12-06 21:09 ` Thierry Reding
2013-12-12  1:08   ` Olof Johansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212010811.GA21856@quad.lixom.net \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox