From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] usb: dwc3: Add Keystone specific glue layer
Date: Thu, 12 Dec 2013 11:35:54 -0600 [thread overview]
Message-ID: <20131212173554.GC1939@saruman.home> (raw)
In-Reply-To: <1386869130-2993-2-git-send-email-w-kwok2@ti.com>
Hi,
On Thu, Dec 12, 2013 at 12:25:29PM -0500, WingMan Kwok wrote:
> +static int kdwc3_remove(struct platform_device *pdev)
> +{
> + struct dwc3_keystone *kdwc = platform_get_drvdata(pdev);
> +
> + kdwc3_disable_irqs(kdwc);
> + clk_disable_unprepare(kdwc->clk);
isn't this same clock feeding dwc3 core ?
> + device_for_each_child(&pdev->dev, NULL, kdwc3_remove_core);
if it is, you should disable the clock only *after* removing the core,
provided core will access registers during remove.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131212/3302c8f3/attachment.sig>
next prev parent reply other threads:[~2013-12-12 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 17:25 [PATCH v4 0/2] Kesytone II USB host and PHY drivers WingMan Kwok
2013-12-12 17:25 ` [PATCH v4 1/2] usb: dwc3: Add Keystone specific glue layer WingMan Kwok
2013-12-12 17:35 ` Felipe Balbi [this message]
2013-12-12 17:25 ` [PATCH v4 2/2] usb: phy: Add keystone usb phy driver WingMan Kwok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212173554.GC1939@saruman.home \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).