[PATCH] pci: designware: fix missing msi irqs

[PATCH] pci: designware: fix missing msi irqs

[Harro Haan]

An embedded and charset-unspecified text was scrubbed...
Name: pci-designware-fix-missing-msi-irqs.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131212/a30964a8/attachment.ksh>

[PATCH] pci: designware: fix missing msi irqs

[Matthias Mann]

Am 12.12.2013 19:29, schrieb Harro Haan:
> The interrupts were cleared after the irq handler was called.
> This means that new interrupts that occur after the handler handled
> the previous irq but before the interrupt is cleared will be missed.

I discovered the same issue today. I'll test that patch tomorrow.

[PATCH] pci: designware: fix missing msi irqs

[Marek Vasut]

On Thursday, December 12, 2013 at 07:29:03 PM, Harro Haan wrote:
> The interrupts were cleared after the irq handler was called.
> This means that new interrupts that occur after the handler handled
> the previous irq but before the interrupt is cleared will be missed.
> 
> Signed-off-by: Harro Haan <hrhaan@gmail.com>
> Cc: Mohit Kumar <mohit.kumar@st.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Richard Zhu <hong-xing.zhu@freescale.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Pratyush Anand <pratyush.anand@st.com>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Juergen Beisert <jbe@pengutronix.de>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Siva Reddy Kallam <siva.kallam@samsung.com>
> Cc: Srikanth T Shivanand <ts.srikanth@samsung.com>
> Cc: Sean Cross <xobs@kosagi.com>
> Cc: linux-pci at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>  drivers/pci/host/pcie-designware.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-designware.c
> b/drivers/pci/host/pcie-designware.c index 1ce0453..762f596 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -167,11 +167,13 @@ void dw_handle_msi_irq(struct pcie_port *pp)
>  			while ((pos = find_next_bit(&val, 32, pos)) != 32) {
>  				irq = irq_find_mapping(pp->irq_domain,
>  						i * 32 + pos);
> +				dw_pcie_wr_own_conf(pp,
> +						PCIE_MSI_INTR0_STATUS + i * 12,
> +						4, 1 << pos);
>  				generic_handle_irq(irq);
>  				pos++;
>  			}
>  		}
> -		dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12, 4, val);
>  	}
>  }

On imx6-sabrelite:

Tested-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

[PATCH] pci: designware: fix missing msi irqs

[Matthias Mann]

Am 12.12.2013 20:29, schrieb Matthias Mann:
> Am 12.12.2013 19:29, schrieb Harro Haan:
>> The interrupts were cleared after the irq handler was called.
>> This means that new interrupts that occur after the handler handled
>> the previous irq but before the interrupt is cleared will be missed.
>
> I discovered the same issue today. I'll test that patch tomorrow.
>
I tested this patch on our custom i.MX6 board with an Altera FPGA as PCIe
device and it fixed the missed MSI interrupts.

Tested-by:  Matthias Mann <m.mann@arkona-technologies.de>

Regards
Matthias Mann

-- 

Matthias Mann
Research & Development

Phone: 	+49 (0) 6155 7802883
Fax: 	+49 (0) 6155 7802880
Email: 	M.Mann at arkona-technologies.de 
<mailto:M.Mann@arkona-technologies.de>
Web: 	www.arkona-technologies.de <http://www.arkona-technologies.de>

arkona technologies GmbH
Im Leuschnerpark 4
64347 Griesheim
Germany

Amtsgericht / Commercial Register of Darmstadt, HRB 90080
USt-ID: DE273794666
Steuernummer / Tax-ID: 007 / 228 / 19331
Gesch?ftsf?hrung / Managing Director: Rainer Sturm

This e-mail may contain confidential and/or privileged information. If you are
not the intended recipient (or have received this e-mail in error) please notify
the sender immediately and delete this message and any attachments from your
system. Any unauthorised copying, disclosure or distribution of the material in
this e-mail is strictly forbidden.

We cannot accept any responsibility for the accuracy or completeness of this
message as it has been transmitted over a public network. If, despite our use of
anti-virus software, a virus enters your systems in connection with the sending
of the e-mail, you may not hold us liable for any damages that may possibly
arise in that connection. We will accept liability which by law we cannot exclude.

[PATCH] pci: designware: fix missing msi irqs

[Jingoo Han]

On Friday, December 13, 2013 3:29 AM, Harro Haan wrote:
> 
> The interrupts were cleared after the irq handler was called.
> This means that new interrupts that occur after the handler handled
> the previous irq but before the interrupt is cleared will be missed.
> 
> Signed-off-by: Harro Haan <hrhaan@gmail.com>
> Cc: Mohit Kumar <mohit.kumar@st.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Richard Zhu <hong-xing.zhu@freescale.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Pratyush Anand <pratyush.anand@st.com>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Juergen Beisert <jbe@pengutronix.de>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Siva Reddy Kallam <siva.kallam@samsung.com>
> Cc: Srikanth T Shivanand <ts.srikanth@samsung.com>
> Cc: Sean Cross <xobs@kosagi.com>
> Cc: linux-pci at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org

Acked-by: Jingoo Han <jg1.han@samsung.com>

I was not able to reproduce the problem, however it looks
good. Also, there is no side effect on Exynos platform.

Mohit,
If you have some comments, please let us know.

Best regards,
Jingoo Han

> ---
>  drivers/pci/host/pcie-designware.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH] pci: designware: fix missing msi irqs

[Mohit KUMAR DCG]

> -----Original Message-----
> From: Jingoo Han [mailto:jg1.han at samsung.com]
> Sent: Monday, December 16, 2013 6:24 AM
> To: 'Harro Haan'; Mohit KUMAR DCG
> Cc: 'Bjorn Helgaas'; 'Marek Vasut'; 'Richard Zhu'; 'Shawn Guo'; Pratyush
> ANAND; 'Tim Harvey'; 'Juergen Beisert'; 'Arnd Bergmann'; 'Siva Reddy
> Kallam'; 'Srikanth T Shivanand'; 'Sean Cross'; linux-pci at vger.kernel.org; linux-
> arm-kernel at lists.infradead.org; 'Jingoo Han'
> Subject: Re: [PATCH] pci: designware: fix missing msi irqs
> 
> On Friday, December 13, 2013 3:29 AM, Harro Haan wrote:
> >
> > The interrupts were cleared after the irq handler was called.
> > This means that new interrupts that occur after the handler handled
> > the previous irq but before the interrupt is cleared will be missed.
> >
> > Signed-off-by: Harro Haan <hrhaan@gmail.com>
> > Cc: Mohit Kumar <mohit.kumar@st.com>
> > Cc: Jingoo Han <jg1.han@samsung.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Richard Zhu <hong-xing.zhu@freescale.com>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Pratyush Anand <pratyush.anand@st.com>
> > Cc: Tim Harvey <tharvey@gateworks.com>
> > Cc: Juergen Beisert <jbe@pengutronix.de>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Siva Reddy Kallam <siva.kallam@samsung.com>
> > Cc: Srikanth T Shivanand <ts.srikanth@samsung.com>
> > Cc: Sean Cross <xobs@kosagi.com>
> > Cc: linux-pci at vger.kernel.org
> > Cc: linux-arm-kernel at lists.infradead.org
> 
> Acked-by: Jingoo Han <jg1.han@samsung.com>
> 
> I was not able to reproduce the problem, however it looks good. Also, there
> is no side effect on Exynos platform.
> 
> Mohit,
> If you have some comments, please let us know.

- Quickly tested on SPEAr1310, working fine without any side effect. So is,
Acked-by: Mohit Kumar <mohit.kumar@st.com>
..
> 
> > ---
> >  drivers/pci/host/pcie-designware.c |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH] pci: designware: fix missing msi irqs

[Jingoo Han]

On Monday, December 16, 2013 3:49 PM, Mohit KUMAR DCG wrote:
> On Monday, December 16, 2013 6:24 AM, Jingoo Han wrote:
> > On Friday, December 13, 2013 3:29 AM, Harro Haan wrote:
> > >
> > > The interrupts were cleared after the irq handler was called.
> > > This means that new interrupts that occur after the handler handled
> > > the previous irq but before the interrupt is cleared will be missed.
> > >
> > > Signed-off-by: Harro Haan <hrhaan@gmail.com>
> > > Cc: Mohit Kumar <mohit.kumar@st.com>
> > > Cc: Jingoo Han <jg1.han@samsung.com>
> > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > Cc: Marek Vasut <marex@denx.de>
> > > Cc: Richard Zhu <hong-xing.zhu@freescale.com>
> > > Cc: Shawn Guo <shawn.guo@linaro.org>
> > > Cc: Pratyush Anand <pratyush.anand@st.com>
> > > Cc: Tim Harvey <tharvey@gateworks.com>
> > > Cc: Juergen Beisert <jbe@pengutronix.de>
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > Cc: Siva Reddy Kallam <siva.kallam@samsung.com>
> > > Cc: Srikanth T Shivanand <ts.srikanth@samsung.com>
> > > Cc: Sean Cross <xobs@kosagi.com>
> > > Cc: linux-pci at vger.kernel.org
> > > Cc: linux-arm-kernel at lists.infradead.org
> >
> > Acked-by: Jingoo Han <jg1.han@samsung.com>
> >
> > I was not able to reproduce the problem, however it looks good. Also, there
> > is no side effect on Exynos platform.
> >
> > Mohit,
> > If you have some comments, please let us know.
> 
> - Quickly tested on SPEAr1310, working fine without any side effect. So is,
> Acked-by: Mohit Kumar <mohit.kumar@st.com>

Hi Bjorn Helgaas,

Would you apply this patch to your 'pci/host-designware' branch
with the following Tested-by and Acked-by?

Tested-by: Marek Vasut <marex@denx.de>
Tested-by:  Matthias Mann <m.mann@arkona-technologies.de>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Mohit Kumar <mohit.kumar@st.com>


> ..
> >
> > > ---
> > >  drivers/pci/host/pcie-designware.c |    4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH] pci: designware: fix missing msi irqs

[Bjorn Helgaas]

On Thu, Dec 19, 2013 at 7:41 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> On Monday, December 16, 2013 3:49 PM, Mohit KUMAR DCG wrote:
>> On Monday, December 16, 2013 6:24 AM, Jingoo Han wrote:
>> > On Friday, December 13, 2013 3:29 AM, Harro Haan wrote:
>> > >
>> > > The interrupts were cleared after the irq handler was called.
>> > > This means that new interrupts that occur after the handler handled
>> > > the previous irq but before the interrupt is cleared will be missed.
>> > >
>> > > Signed-off-by: Harro Haan <hrhaan@gmail.com>
>> > > Cc: Mohit Kumar <mohit.kumar@st.com>
>> > > Cc: Jingoo Han <jg1.han@samsung.com>
>> > > Cc: Bjorn Helgaas <bhelgaas@google.com>
>> > > Cc: Marek Vasut <marex@denx.de>
>> > > Cc: Richard Zhu <hong-xing.zhu@freescale.com>
>> > > Cc: Shawn Guo <shawn.guo@linaro.org>
>> > > Cc: Pratyush Anand <pratyush.anand@st.com>
>> > > Cc: Tim Harvey <tharvey@gateworks.com>
>> > > Cc: Juergen Beisert <jbe@pengutronix.de>
>> > > Cc: Arnd Bergmann <arnd@arndb.de>
>> > > Cc: Siva Reddy Kallam <siva.kallam@samsung.com>
>> > > Cc: Srikanth T Shivanand <ts.srikanth@samsung.com>
>> > > Cc: Sean Cross <xobs@kosagi.com>
>> > > Cc: linux-pci at vger.kernel.org
>> > > Cc: linux-arm-kernel at lists.infradead.org
>> >
>> > Acked-by: Jingoo Han <jg1.han@samsung.com>
>> >
>> > I was not able to reproduce the problem, however it looks good. Also, there
>> > is no side effect on Exynos platform.
>> >
>> > Mohit,
>> > If you have some comments, please let us know.
>>
>> - Quickly tested on SPEAr1310, working fine without any side effect. So is,
>> Acked-by: Mohit Kumar <mohit.kumar@st.com>
>
> Hi Bjorn Helgaas,
>
> Would you apply this patch to your 'pci/host-designware' branch
> with the following Tested-by and Acked-by?
>
> Tested-by: Marek Vasut <marex@denx.de>
> Tested-by:  Matthias Mann <m.mann@arkona-technologies.de>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
> Acked-by: Mohit Kumar <mohit.kumar@st.com>

Applied to pci/host-designware for v3.14, thanks for the reminder!

Bjorn