From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: reinsert ARCH_MULTI_V4 Kconfig option
Date: Fri, 13 Dec 2013 11:39:03 +0000 [thread overview]
Message-ID: <20131213113903.GE4360@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CACmBeS1d-EX5oPD8f7P-ufmF=MutdTO+LgG23Cb0=biR8yQPCg@mail.gmail.com>
On Fri, Dec 13, 2013 at 11:51:09AM +0100, Jonas Jensen wrote:
> On 13 December 2013 10:56, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > So, having these symbols enabled (provided the right ones for FA526 are
> > also enabled) makes no difference. So I don't buy your explanation.
>
> The explanation is indeed false, CPU_FA526 and CPU_ARM920T get along just fine.
> That's not where the problem is.
>
> Panic goes away after removing CONFIG_ARM_THUMB=y.
>
> I assume this is what should happen on processors without thumb?
I see what's causing this: the kuser helpers are using "bx lr" to return
which will be undefined on non-Thumb CPUs. We generally cope fine with
non-Thumb CPUs, conditionalising where necessary on HWCAP_THUMB or the
T bit in the PSR being set.
However, it looks like the kuser helpers got missed. As a check, please
look at arch/arm/kernel/entry-armv.S, find the line with:
.macro usr_ret, reg
and ensure that the mov pc, \reg case always gets used. Please report
back.
Thanks.
next prev parent reply other threads:[~2013-12-13 11:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 8:09 [PATCH] ARM: reinsert ARCH_MULTI_V4 Kconfig option Jonas Jensen
2013-12-13 9:56 ` Russell King - ARM Linux
2013-12-13 10:51 ` Jonas Jensen
2013-12-13 11:39 ` Russell King - ARM Linux [this message]
2013-12-13 13:33 ` Jonas Jensen
2014-04-09 14:54 ` Jonas Jensen
2014-04-09 15:04 ` Uwe Kleine-König
2014-04-09 15:09 ` Russell King - ARM Linux
2014-04-09 15:06 ` Russell King - ARM Linux
2014-04-09 15:13 ` Uwe Kleine-König
2014-04-09 15:27 ` Russell King - ARM Linux
2014-04-09 15:50 ` Arnd Bergmann
2014-04-09 16:01 ` Russell King - ARM Linux
2014-04-10 8:04 ` Jonas Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213113903.GE4360@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).