From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: clps711x: Add CLPS711X irqchip driver
Date: Sat, 14 Dec 2013 09:27:15 +0400 [thread overview]
Message-ID: <20131214092715.6735074a15ce6128d128875f@mail.ru> (raw)
In-Reply-To: <201312071714.25454.arnd@arndb.de>
On Sat, 7 Dec 2013 17:14:25 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> On Saturday 07 December 2013, Alexander Shiyan wrote:
> > > > +void __init clps711x_intc_init(phys_addr_t base, resource_size_t size)
> > > > +{
> > > > + BUG_ON(_clps711x_intc_init(NULL, base, size));
> > > > +}
> > > > +EXPORT_SYMBOL(clps711x_intc_init);
> > >
> > > No need to export this symbol, because you don't call the function from
> > > loadable modules.
> >
> > OK. I will remove it in the next version by adding "maybe_unused" to this
> > function to avoid possible warnings.
>
> The __maybe_unused should not be needed, as the function will still have
> global scope.
Arnd can you merge this series with manual EXPORT_SYMBOL removal? Resend?
--
Alexander Shiyan <shc_work@mail.ru>
next prev parent reply other threads:[~2013-12-14 5:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 18:14 [PATCH 1/3] ARM: clps711x: Add CLPS711X irqchip driver Alexander Shiyan
2013-12-02 18:14 ` [PATCH 3/3] ARM: clps711x: Migrate CLPS711X subarch to the new " Alexander Shiyan
2013-12-07 14:30 ` Arnd Bergmann
2013-12-07 14:30 ` [PATCH 1/3] ARM: clps711x: Add CLPS711X " Arnd Bergmann
2013-12-07 14:40 ` Alexander Shiyan
2013-12-07 16:14 ` Arnd Bergmann
2013-12-07 16:27 ` Alexander Shiyan
2013-12-14 5:27 ` Alexander Shiyan [this message]
2013-12-14 12:31 ` Arnd Bergmann
2013-12-18 16:35 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214092715.6735074a15ce6128d128875f@mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).