* [PATCH 02/10] arm: select ARCH_MIGHT_HAVE_PC_SERIO [not found] <1387040376-26906-1-git-send-email-msalter@redhat.com> @ 2013-12-14 16:59 ` Mark Salter 2013-12-14 18:41 ` Russell King - ARM Linux 2013-12-14 16:59 ` [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter 1 sibling, 1 reply; 9+ messages in thread From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw) To: linux-arm-kernel Architectures which might use an i8042 for serial IO to keyboard, mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO. Signed-off-by: Mark Salter <msalter@redhat.com> CC: Russell King <linux@arm.linux.org.uk> CC: linux-arm-kernel at lists.infradead.org --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index c1f1a7e..6990dc5 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -6,6 +6,7 @@ config ARM select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST select ARCH_HAVE_CUSTOM_GPIO_H select ARCH_MIGHT_HAVE_PC_PARPORT + select ARCH_MIGHT_HAVE_PC_SERIO if FOOTBRIDGE_HOST select ARCH_USE_CMPXCHG_LOCKREF select ARCH_WANT_IPC_PARSE_VERSION select BUILDTIME_EXTABLE_SORT if MMU -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 02/10] arm: select ARCH_MIGHT_HAVE_PC_SERIO 2013-12-14 16:59 ` [PATCH 02/10] arm: select ARCH_MIGHT_HAVE_PC_SERIO Mark Salter @ 2013-12-14 18:41 ` Russell King - ARM Linux 0 siblings, 0 replies; 9+ messages in thread From: Russell King - ARM Linux @ 2013-12-14 18:41 UTC (permalink / raw) To: linux-arm-kernel On Sat, Dec 14, 2013 at 11:59:28AM -0500, Mark Salter wrote: > Architectures which might use an i8042 for serial IO to keyboard, > mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO. > > Signed-off-by: Mark Salter <msalter@redhat.com> > CC: Russell King <linux@arm.linux.org.uk> > CC: linux-arm-kernel at lists.infradead.org > --- > arch/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index c1f1a7e..6990dc5 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -6,6 +6,7 @@ config ARM > select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST > select ARCH_HAVE_CUSTOM_GPIO_H > select ARCH_MIGHT_HAVE_PC_PARPORT > + select ARCH_MIGHT_HAVE_PC_SERIO if FOOTBRIDGE_HOST > select ARCH_USE_CMPXCHG_LOCKREF > select ARCH_WANT_IPC_PARSE_VERSION > select BUILDTIME_EXTABLE_SORT if MMU It would be better to put this in arch/arm/mach-footbridge/Kconfig - ARM is impled as being true there. Thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies [not found] <1387040376-26906-1-git-send-email-msalter@redhat.com> 2013-12-14 16:59 ` [PATCH 02/10] arm: select ARCH_MIGHT_HAVE_PC_SERIO Mark Salter @ 2013-12-14 16:59 ` Mark Salter 2013-12-14 18:32 ` H. Peter Anvin 2013-12-16 16:23 ` Ralf Baechle 1 sibling, 2 replies; 9+ messages in thread From: Mark Salter @ 2013-12-14 16:59 UTC (permalink / raw) To: linux-arm-kernel Remove messy dependencies from SERIO_I8042 by having it depend on one Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig. New architectures are unlikely to need SERIO_I8042, so this avoids having an ever growing list of architectures to exclude. Signed-off-by: Mark Salter <msalter@redhat.com> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com> CC: Richard Henderson <rth@twiddle.net> CC: linux-alpha at vger.kernel.org CC: Russell King <linux@arm.linux.org.uk> CC: linux-arm-kernel at lists.infradead.org CC: Tony Luck <tony.luck@intel.com> CC: Fenghua Yu <fenghua.yu@intel.com> CC: linux-ia64 at vger.kernel.org CC: Ralf Baechle <ralf@linux-mips.org> CC: linux-mips at linux-mips.org CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> CC: Paul Mackerras <paulus@samba.org> CC: linuxppc-dev at lists.ozlabs.org CC: Paul Mundt <lethal@linux-sh.org> CC: linux-sh at vger.kernel.org CC: "David S. Miller" <davem@davemloft.net> CC: sparclinux at vger.kernel.org CC: Guan Xuetao <gxt@mprc.pku.edu.cn> CC: Ingo Molnar <mingo@redhat.com> CC: Thomas Gleixner <tglx@linutronix.de> CC: "H. Peter Anvin" <hpa@zytor.com> CC: x86 at kernel.org --- drivers/input/serio/Kconfig | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index 8541f94..1f5cec2 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig @@ -16,14 +16,19 @@ config SERIO To compile this driver as a module, choose M here: the module will be called serio. +config ARCH_MIGHT_HAVE_PC_SERIO + bool + help + Select this config option from the architecture Kconfig if + the architecture might use a PC serio device (i8042) to + communicate with keyboard, mouse, etc. + if SERIO config SERIO_I8042 tristate "i8042 PC Keyboard controller" default y - depends on !PARISC && (!ARM || FOOTBRIDGE_HOST) && \ - (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !S390 && \ - !ARC + depends on ARCH_MIGHT_HAVE_PC_SERIO help i8042 is the chip over which the standard AT keyboard and PS/2 mouse are connected to the computer. If you use these devices, -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies 2013-12-14 16:59 ` [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter @ 2013-12-14 18:32 ` H. Peter Anvin 2013-12-15 10:36 ` Dmitry Torokhov 2013-12-16 16:23 ` Ralf Baechle 1 sibling, 1 reply; 9+ messages in thread From: H. Peter Anvin @ 2013-12-14 18:32 UTC (permalink / raw) To: linux-arm-kernel On 12/14/2013 08:59 AM, Mark Salter wrote: > Remove messy dependencies from SERIO_I8042 by having it depend on one > Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures > which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig. > New architectures are unlikely to need SERIO_I8042, so this avoids > having an ever growing list of architectures to exclude. > > Signed-off-by: Mark Salter <msalter@redhat.com> > CC: Dmitry Torokhov <dmitry.torokhov@gmail.com> > CC: Richard Henderson <rth@twiddle.net> > CC: linux-alpha at vger.kernel.org > CC: Russell King <linux@arm.linux.org.uk> > CC: linux-arm-kernel at lists.infradead.org > CC: Tony Luck <tony.luck@intel.com> > CC: Fenghua Yu <fenghua.yu@intel.com> > CC: linux-ia64 at vger.kernel.org > CC: Ralf Baechle <ralf@linux-mips.org> > CC: linux-mips at linux-mips.org > CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> > CC: Paul Mackerras <paulus@samba.org> > CC: linuxppc-dev at lists.ozlabs.org > CC: Paul Mundt <lethal@linux-sh.org> > CC: linux-sh at vger.kernel.org > CC: "David S. Miller" <davem@davemloft.net> > CC: sparclinux at vger.kernel.org > CC: Guan Xuetao <gxt@mprc.pku.edu.cn> > CC: Ingo Molnar <mingo@redhat.com> > CC: Thomas Gleixner <tglx@linutronix.de> > CC: "H. Peter Anvin" <hpa@zytor.com> > CC: x86 at kernel.org Acked-by: H. Peter Anvin <hpa@linux.intel.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies 2013-12-14 18:32 ` H. Peter Anvin @ 2013-12-15 10:36 ` Dmitry Torokhov 2013-12-15 15:50 ` Mark Salter 0 siblings, 1 reply; 9+ messages in thread From: Dmitry Torokhov @ 2013-12-15 10:36 UTC (permalink / raw) To: linux-arm-kernel On Sat, Dec 14, 2013 at 10:32:31AM -0800, H. Peter Anvin wrote: > On 12/14/2013 08:59 AM, Mark Salter wrote: > > Remove messy dependencies from SERIO_I8042 by having it depend on one > > Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures > > which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig. > > New architectures are unlikely to need SERIO_I8042, so this avoids > > having an ever growing list of architectures to exclude. > > > > Signed-off-by: Mark Salter <msalter@redhat.com> > > CC: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > CC: Richard Henderson <rth@twiddle.net> > > CC: linux-alpha at vger.kernel.org > > CC: Russell King <linux@arm.linux.org.uk> > > CC: linux-arm-kernel at lists.infradead.org > > CC: Tony Luck <tony.luck@intel.com> > > CC: Fenghua Yu <fenghua.yu@intel.com> > > CC: linux-ia64 at vger.kernel.org > > CC: Ralf Baechle <ralf@linux-mips.org> > > CC: linux-mips at linux-mips.org > > CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > CC: Paul Mackerras <paulus@samba.org> > > CC: linuxppc-dev at lists.ozlabs.org > > CC: Paul Mundt <lethal@linux-sh.org> > > CC: linux-sh at vger.kernel.org > > CC: "David S. Miller" <davem@davemloft.net> > > CC: sparclinux at vger.kernel.org > > CC: Guan Xuetao <gxt@mprc.pku.edu.cn> > > CC: Ingo Molnar <mingo@redhat.com> > > CC: Thomas Gleixner <tglx@linutronix.de> > > CC: "H. Peter Anvin" <hpa@zytor.com> > > CC: x86 at kernel.org > > Acked-by: H. Peter Anvin <hpa@linux.intel.com> How are we going to merge this? In bulk through input tree or peacemeal through all arches first? -- Dmitry ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies 2013-12-15 10:36 ` Dmitry Torokhov @ 2013-12-15 15:50 ` Mark Salter 2013-12-16 1:27 ` David Miller 0 siblings, 1 reply; 9+ messages in thread From: Mark Salter @ 2013-12-15 15:50 UTC (permalink / raw) To: linux-arm-kernel On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote: > On Sat, Dec 14, 2013 at 10:32:31AM -0800, H. Peter Anvin wrote: > > On 12/14/2013 08:59 AM, Mark Salter wrote: > > > Remove messy dependencies from SERIO_I8042 by having it depend on one > > > Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures > > > which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig. > > > New architectures are unlikely to need SERIO_I8042, so this avoids > > > having an ever growing list of architectures to exclude. > How are we going to merge this? In bulk through input tree or peacemeal > through all arches first? > They should all go together to eliminate the chance of bisect breakage. Either the input tree or maybe akpm tree. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies 2013-12-15 15:50 ` Mark Salter @ 2013-12-16 1:27 ` David Miller 2013-12-16 4:59 ` Dmitry Torokhov 0 siblings, 1 reply; 9+ messages in thread From: David Miller @ 2013-12-16 1:27 UTC (permalink / raw) To: linux-arm-kernel From: Mark Salter <msalter@redhat.com> Date: Sun, 15 Dec 2013 10:50:26 -0500 > On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote: >> How are we going to merge this? In bulk through input tree or peacemeal >> through all arches first? > > They should all go together to eliminate the chance of bisect breakage. > Either the input tree or maybe akpm tree. This sounds good to me. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies 2013-12-16 1:27 ` David Miller @ 2013-12-16 4:59 ` Dmitry Torokhov 0 siblings, 0 replies; 9+ messages in thread From: Dmitry Torokhov @ 2013-12-16 4:59 UTC (permalink / raw) To: linux-arm-kernel On Sun, Dec 15, 2013 at 08:27:25PM -0500, David Miller wrote: > From: Mark Salter <msalter@redhat.com> > Date: Sun, 15 Dec 2013 10:50:26 -0500 > > > On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote: > >> How are we going to merge this? In bulk through input tree or peacemeal > >> through all arches first? > > > > They should all go together to eliminate the chance of bisect breakage. > > Either the input tree or maybe akpm tree. > > This sounds good to me. OK, then I'll pick it up once I collect more acks from the arch maintainers. -- Dmitry ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies 2013-12-14 16:59 ` [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter 2013-12-14 18:32 ` H. Peter Anvin @ 2013-12-16 16:23 ` Ralf Baechle 1 sibling, 0 replies; 9+ messages in thread From: Ralf Baechle @ 2013-12-16 16:23 UTC (permalink / raw) To: linux-arm-kernel On Sat, Dec 14, 2013 at 11:59:36AM -0500, Mark Salter wrote: > - depends on !PARISC && (!ARM || FOOTBRIDGE_HOST) && \ > - (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !S390 && \ > - !ARC > + depends on ARCH_MIGHT_HAVE_PC_SERIO Most dependencies on an architecture's kconfig symbol outside arch/ should probably be treated as a bug. Acked-by: Ralf Baechle <ralf@linux-mips.org> Ralf ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-12-16 16:23 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <1387040376-26906-1-git-send-email-msalter@redhat.com> 2013-12-14 16:59 ` [PATCH 02/10] arm: select ARCH_MIGHT_HAVE_PC_SERIO Mark Salter 2013-12-14 18:41 ` Russell King - ARM Linux 2013-12-14 16:59 ` [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies Mark Salter 2013-12-14 18:32 ` H. Peter Anvin 2013-12-15 10:36 ` Dmitry Torokhov 2013-12-15 15:50 ` Mark Salter 2013-12-16 1:27 ` David Miller 2013-12-16 4:59 ` Dmitry Torokhov 2013-12-16 16:23 ` Ralf Baechle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).