linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: dts: sun5i: Add new sun5i-a13-olinuxino-micro board
Date: Sun, 15 Dec 2013 15:04:57 +0100	[thread overview]
Message-ID: <20131215140457.GG3651@lukather> (raw)
In-Reply-To: <1387058295-20641-4-git-send-email-hdegoede@redhat.com>

On Sat, Dec 14, 2013 at 10:58:13PM +0100, Hans de Goede wrote:
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Commit log :)

Please detail what the board is, what features it has, etc.

Other than that, I'm mostly ok with this patch (except that you can
also probably add your copyright, but that's your call :))

Could you send it as a single patch, separate from this serie (since
it's not really related in the end).

Thanks!
Maxime

> ---
>  arch/arm/boot/dts/Makefile                      |  1 +
>  arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 66 +++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d57c1a6..b663ed7 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -255,6 +255,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += \
>  	sun4i-a10-hackberry.dtb \
>  	sun5i-a10s-olinuxino-micro.dtb \
>  	sun5i-a13-olinuxino.dtb \
> +	sun5i-a13-olinuxino-micro.dtb \
>  	sun6i-a31-colombus.dtb \
>  	sun7i-a20-cubieboard2.dtb \
>  	sun7i-a20-cubietruck.dtb \
> diff --git a/arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts b/arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts
> new file mode 100644
> index 0000000..26df7e8
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts
> @@ -0,0 +1,66 @@
> +/*
> + * Copyright 2012 Maxime Ripard
> + *
> + * Maxime Ripard <maxime.ripard@free-electrons.com>
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +/include/ "sun5i-a13.dtsi"
> +
> +/ {
> +	model = "Olimex A13-Olinuxino Micro";
> +	compatible = "olimex,a13-olinuxino-micro", "allwinner,sun5i-a13";
> +
> +	soc at 01c00000 {
> +		pinctrl at 01c20800 {
> +			led_pins_olinuxinom: led_pins at 0 {
> +				allwinner,pins = "PG9";
> +				allwinner,function = "gpio_out";
> +				allwinner,drive = <1>;
> +				allwinner,pull = <0>;
> +			};
> +		};
> +
> +		uart1: serial at 01c28400 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&uart1_pins_b>;
> +			status = "okay";
> +		};
> +
> +		i2c0: i2c at 01c2ac00 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c0_pins_a>;
> +			status = "okay";
> +		};
> +
> +		i2c1: i2c at 01c2b000 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c1_pins_a>;
> +			status = "okay";
> +		};
> +
> +		i2c2: i2c at 01c2b400 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c2_pins_a>;
> +			status = "okay";
> +		};
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&led_pins_olinuxinom>;
> +
> +		power {

Could you add a label here?

Something like a13-olinuxino-micro:green:power ?

> +			gpios = <&pio 6 9 0>;
> +			default-state = "on";
> +		};
> +	};
> +};

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131215/0c6225d3/attachment-0001.sig>

  reply	other threads:[~2013-12-15 14:04 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-14 21:58 [PATCH 0/5] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs Hans de Goede
2013-12-14 21:58 ` [PATCH 1/5] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs Hans de Goede
2013-12-15 13:44   ` Maxime Ripard
2013-12-15 14:20     ` Hans de Goede
2013-12-15 16:21       ` Maxime Ripard
2013-12-15 18:41         ` [linux-sunxi] " Hans de Goede
2013-12-15 19:35           ` David Lanzendörfer
2013-12-15 20:18             ` Hans de Goede
2013-12-15 21:19               ` David Lanzendörfer
2013-12-16 12:21                 ` Hans de Goede
2013-12-23 10:36                   ` David Lanzendörfer
2013-12-15 16:33       ` David Lanzendörfer
2013-12-15 22:01     ` [linux-sunxi] " Michal Suchanek
2013-12-16 10:05       ` Maxime Ripard
2013-12-16 11:59         ` Michal Suchanek
2013-12-16 12:49           ` Ian Campbell
2013-12-16 12:53           ` Maxime Ripard
2014-02-05 13:33     ` David Lanzendörfer
2013-12-17 13:43   ` Mark Brown
2013-12-14 21:58 ` [PATCH 2/5] ARM: dts: sun4i: Add support for mmc Hans de Goede
2013-12-15 13:58   ` Maxime Ripard
2013-12-15 14:31     ` [linux-sunxi] " Hans de Goede
2013-12-15 21:44       ` Henrik Nordström
2013-12-16  9:04       ` David Lanzendörfer
2013-12-16 12:32         ` Hans de Goede
2013-12-16 10:02       ` Maxime Ripard
2013-12-16 12:34         ` Hans de Goede
2013-12-14 21:58 ` [PATCH 3/5] ARM: dts: sun5i: Add new sun5i-a13-olinuxino-micro board Hans de Goede
2013-12-15 14:04   ` Maxime Ripard [this message]
2013-12-14 21:58 ` [PATCH 4/5] ARM: dts: sun5i: add mmc support Hans de Goede
2013-12-14 21:58 ` [PATCH 5/5] ARM: dts: sun7i: Add support for mmc Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131215140457.GG3651@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).