linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: at91sam9: include <mach/hardware.h> explicitly
Date: Mon, 16 Dec 2013 00:11:58 -0800	[thread overview]
Message-ID: <20131216001158.0e15e93c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20131126183629.GK28642@pengutronix.de>

On Tue, 26 Nov 2013 19:36:29 +0100 Uwe Kleine-K__nig <u.kleine-koenig@pengutronix.de> wrote:

> Hello Andrew,
> 
> On Tue, Nov 26, 2013 at 02:44:44PM +0100, Uwe Kleine-K__nig wrote:
> > On Tue, Nov 26, 2013 at 02:41:17PM +0100, Uwe Kleine-K__nig wrote:
> > > On Fri, Nov 15, 2013 at 03:00:58PM +0100, Uwe Kleine-K__nig wrote:
> > > > The driver needs the symbol AT91_SLOW_CLOCK which is defined in
> > > > arch/arm/mach-at91/include/mach/hardware.h. This file is included
> > > > implicitly via linux/module.h -> linux/kmod.h -> linux/gfp.h ->
> > > > linux/mmzone.h -> linux/memory_hotplug.h -> linux/notifier.h ->
> > > > linux/srcu.h -> linux/workqueue.h -> linux/timer.h -> linux/ktime.h ->
> > > > linux/jiffies.h -> linux/timex.h -> mach/timex.h -> mach/hardware.h .
> > > > 
> > > > So better include it explicitly not only because the last link will go
> > > > away soon.
> > > > 
> > > > Signed-off-by: Uwe Kleine-K__nig <u.kleine-koenig@pengutronix.de>
> > > Ping. Is this patch ok despite Jean-Christophe's objection?
> > I saw that akpm already took it into his tree.
> This patch is one of the last few that are needed to drop <mach/timex.h>
> alltogether that I don't have an ack from the respective maintainer yet.
> 
> Can you give your ack instead of sending the patch to Linus, then I'd
> take it with the patch dropping <mach/timex.h> to make it easier to
> merge.

ack ;)

I dropped my copy.

  reply	other threads:[~2013-12-16  8:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 14:00 [PATCH] rtc: at91sam9: include <mach/hardware.h> explicitly Uwe Kleine-König
2013-11-15 14:23 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-15 14:55   ` Uwe Kleine-König
2013-11-27  8:49     ` Nicolas Ferre
2013-11-26 13:41 ` Uwe Kleine-König
2013-11-26 13:44   ` Uwe Kleine-König
2013-11-26 18:36     ` Uwe Kleine-König
2013-12-16  8:11       ` Andrew Morton [this message]
2013-12-16 19:28         ` Uwe Kleine-König
2013-12-16 22:46           ` Andrew Morton
2013-12-17  8:15             ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216001158.0e15e93c.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).