From: l.majewski@samsung.com (Lukasz Majewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] cpufreq: exynos: Add exynos5420 cpufreq driver
Date: Tue, 17 Dec 2013 10:09:56 +0100 [thread overview]
Message-ID: <20131217100956.6fa5b7e6@amdc2363> (raw)
In-Reply-To: <CALt3h79iuOnmeCBxHjPN3qAoiuwHYBXAp_eSTDewxc96zqSOOg@mail.gmail.com>
Hi Arun,
> Hi Lukasz,
>
> On Tue, Dec 17, 2013 at 1:30 PM, Lukasz Majewski
> <l.majewski@samsung.com> wrote:
> > Hi Viresh,
> >
> >> On 6 December 2013 15:18, Arun Kumar K <arun.kk@samsung.com> wrote:
> >> > From: "Arjun.K.V" <arjun.kv@samsung.com>
> >> >
> >> > The patch adds cpufreq driver for exynos5420.
> >> >
> >> > Signed-off-by: Arjun.K.V <arjun.kv@samsung.com>
> >> > Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> >> > Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> >> > ---
> >> > drivers/cpufreq/Kconfig.arm | 11 ++
> >> > drivers/cpufreq/Makefile | 1 +
> >> > drivers/cpufreq/exynos-cpufreq.c | 2 +
> >> > drivers/cpufreq/exynos-cpufreq.h | 8 +
> >> > drivers/cpufreq/exynos5420-cpufreq.c | 346
> >> > ++++++++++++++++++++++++++++++++++ 5 files changed, 368
> >> > insertions(+) create mode 100644
> >> > drivers/cpufreq/exynos5420-cpufreq.c
> >>
> >> Hmm.. That's the second big LITTLE SoC after TC2..
> >> And we already have a generic enough driver for all big LITTLE
> >> platforms: arm_big_little.c
> >>
> >> Please use that with a glue clk and regulator driver if required.
> >> We don't want to get any new driver for big LITTLE unless there is
> >> a real limitation.
> >>
> >> Also, the generic big LITTLE driver supports IKS (In Kernel
> >> Switcher) which may or maynot be used by Exynos.
> >>
> >> @Lukasz: We can't use cpu0 driver here as we have multiple clusters
> >> here A7 and A15, and so there are two clock domains instead of one.
> >> That's why we have written big LITTLE driver.
> >
> > When I first looked into the patch - it was almost identical to the
> > exynos4210-cpufreq.c or exynos4x12-cpufreq.c files.
> >
> > Also I didn't spot the code characteristic to IKS. It seems like the
> > code in this file is not aware if it runs on A7 or A15.
> >
>
> This initial version was only for A15s and I was planning for an
> incremental patch for A7s along with common code for the same. Now
> that is not needed with the generic implementation in place.
Ok. I see.
>
> Regards
> Arun
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2013-12-17 9:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 9:48 [PATCH 0/3] Exynos5420 Cpufreq support Arun Kumar K
2013-12-06 9:48 ` [PATCH 1/3] ARM: EXYNOS: Add exynos5 CPU clock divider offsets Arun Kumar K
2013-12-20 21:23 ` Kukjin Kim
2013-12-06 9:48 ` [PATCH 2/3] clk: exynos5420: Add alias names for cpu clocks Arun Kumar K
2013-12-19 8:00 ` Mike Turquette
2013-12-06 9:48 ` [PATCH 3/3] cpufreq: exynos: Add exynos5420 cpufreq driver Arun Kumar K
2013-12-09 8:23 ` Lukasz Majewski
2013-12-10 4:40 ` Arun Kumar K
2013-12-10 16:32 ` Lukasz Majewski
2013-12-17 7:07 ` Jassi Brar
2013-12-17 8:14 ` Lukasz Majewski
2013-12-17 8:21 ` Arun Kumar K
2013-12-17 6:12 ` Viresh Kumar
2013-12-17 8:00 ` Lukasz Majewski
2013-12-17 8:03 ` Viresh Kumar
2013-12-17 8:05 ` Arun Kumar K
2013-12-17 9:09 ` Lukasz Majewski [this message]
2013-12-17 8:03 ` Arun Kumar K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217100956.6fa5b7e6@amdc2363 \
--to=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).