From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] thermal: imx: add necessary clk operation
Date: Thu, 19 Dec 2013 08:24:50 +0200 [thread overview]
Message-ID: <20131219062450.GC4148@tarshish> (raw)
In-Reply-To: <1387477045-19037-2-git-send-email-b20788@freescale.com>
Hi Anson,
On Thu, Dec 19, 2013 at 01:17:24PM -0500, Anson Huang wrote:
> + if (IS_ERR(data->thermal_clk)) {
> + ret = IS_ERR(data->thermal_clk);
You probably what to return PTR_ERR here.
baruch
> + dev_err(&pdev->dev, "failed to get thermal clk!\n");
> + return ret;
> + }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2013-12-19 6:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 18:17 [PATCH 1/3] ARM: dts: imx6qdl: add necessary thermal clk Anson Huang
2013-12-19 7:06 ` Shawn Guo
2013-12-19 18:17 ` [PATCH 2/3] thermal: imx: add necessary clk operation Anson Huang
2013-12-19 6:24 ` Baruch Siach [this message]
2013-12-19 6:52 ` Anson.Huang at freescale.com
2013-12-19 6:59 ` Shawn Guo
2013-12-19 7:08 ` Anson.Huang at freescale.com
2013-12-19 7:29 ` Shawn Guo
2013-12-19 7:33 ` Anson.Huang at freescale.com
2013-12-19 18:17 ` [PATCH 3/3] thermal: imx: add clk info for thermal sensor Anson Huang
2013-12-19 6:57 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219062450.GC4148@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).