From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/9] ASoC: fsl-ssi: Fix probe error handling
Date: Fri, 20 Dec 2013 10:52:23 +0100 [thread overview]
Message-ID: <20131220095223.GG23493@pengutronix.de> (raw)
In-Reply-To: <20131219130334.GZ31886@sirena.org.uk>
Hi,
On Thu, Dec 19, 2013 at 01:03:34PM +0000, Mark Brown wrote:
> On Wed, Dec 18, 2013 at 12:57:37PM +0100, Markus Pargmann wrote:
> > This patch fixes the error handling in the fsl-ssi probe function.
>
> This doesn't apply against current code, please check and resend.
Okay, I will rebase on your topic/fsl again.
>
> > error_irqmap:
> > - irq_dispose_mapping(ssi_private->irq);
> > + if (ssi_private->use_dma && !of_device_is_compatible(pdev->dev.of_node,
> > + "fsl,imx21-ssi"))
> > + irq_dispose_mapping(ssi_private->irq);
>
> This test is icky, a flag set when we create the mapping would be neter.
Fixed.
Thanks,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-12-20 9:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 11:57 [PATCH v3 0/9] ASoC: fsl-ssi: offline/online configuration and cleanups Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 1/9] ASoC: fsl-ssi: Fix probe error handling Markus Pargmann
2013-12-19 13:03 ` Mark Brown
2013-12-20 9:52 ` Markus Pargmann [this message]
2013-12-18 11:57 ` [PATCH v3 2/9] ASoC: fsl-ssi: Move sysfs stats to debugfs Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 3/9] ASoC: fsl-ssi: Add imx51-ssi and of_device_id matching Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 4/9] ASoC: fsl-ssi: Fix interrupt mapping and release Markus Pargmann
2013-12-20 9:05 ` Nicolin Chen
2013-12-20 10:31 ` Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 5/9] ASoC: fsl-ssi: Add offline_config flag Markus Pargmann
2013-12-19 13:16 ` Mark Brown
2013-12-20 10:08 ` Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 6/9] ASoC: fsl-ssi: Add configuration helper functions Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 7/9] ASoC: fsl-ssi: Move RX/TX configuration to seperate functions Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 8/9] ASoC: fsl-ssi: Drop ac97 specific trigger function Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 9/9] ARM: DTS: imx5* imx6*, use imx51-ssi Markus Pargmann
2013-12-18 13:58 ` Shawn Guo
2013-12-18 14:10 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220095223.GG23493@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).