From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: dts: Reduce size of virtio block device for foundation model
Date: Fri, 20 Dec 2013 16:34:01 +0000 [thread overview]
Message-ID: <20131220163401.GK25477@arm.com> (raw)
In-Reply-To: <20131220160522.GX31886@sirena.org.uk>
On Fri, Dec 20, 2013 at 04:05:22PM +0000, Mark Brown wrote:
> On Fri, Dec 20, 2013 at 02:25:24PM +0000, Catalin Marinas wrote:
> > On Fri, Dec 20, 2013 at 12:52:44PM +0000, Mark Brown wrote:
> > > From: Mark Brown <broonie@linaro.org>
>
> > > Will Deacon observed that kvmtool uses a size of 0x200 for virtio
> > > block memory region and that the virtio block spec only uses 31 bytes in
> > > the device specific region at 0x100 so reduce the region to a less
> > > wasteful 0x200.
>
> > What do we waste by keeping it at 4K? That's ioremap'ed, so we use a
> > full page anyway.
>
> This was done for consistency with the same change made in RTSM
> motherboard patch so that we register the same device in the same way.
> That change was at Will's request, he did point out that we might use
> 16K pages in some systems IIRC but personally I'm not sure it makes a
> huge difference either way - I do think we should keep all registrations
> of the device consistent though to avoid user confusion about how to use
> it.
OK. Applied.
--
Catalin
next prev parent reply other threads:[~2013-12-20 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 12:52 [PATCH 1/2] arm64: dts: Add a virtio disk to the RTSM motherboard Mark Brown
2013-12-20 12:52 ` [PATCH 2/2] arm64: dts: Reduce size of virtio block device for foundation model Mark Brown
2013-12-20 14:25 ` Catalin Marinas
2013-12-20 16:05 ` Mark Brown
2013-12-20 16:34 ` Catalin Marinas [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-03 19:58 [PATCH 1/2] arm64: dts: Add a virtio disk to the RTSM motherboard Mark Brown
2013-12-03 19:58 ` [PATCH 2/2] arm64: dts: Reduce size of virtio block device for foundation model Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220163401.GK25477@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).