From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: musb: Remove USB_GADGET driver dependency
Date: Fri, 20 Dec 2013 14:05:42 -0300 [thread overview]
Message-ID: <20131220170541.GA16652@localhost> (raw)
In-Reply-To: <20131220154958.GA5957@saruman.home>
On Fri, Dec 20, 2013 at 09:49:58AM -0600, Felipe Balbi wrote:
> On Thu, Dec 19, 2013 at 10:20:48PM -0300, Ezequiel Garcia wrote:
> > This USB controller is dual-role, but can also work in host-only mode.
> > There's no reason to condition the entire driver to USB_GADGET. Fix this by
> > removing the dependency.
> >
> > Tested on a Beaglebone black (AM335x) using a regular USB mass storage
> > device.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > ---
> > drivers/usb/musb/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> > index 57dfc0c..2119370 100644
> > --- a/drivers/usb/musb/Kconfig
> > +++ b/drivers/usb/musb/Kconfig
> > @@ -6,7 +6,6 @@
> > # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
> > config USB_MUSB_HDRC
> > tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
> > - depends on USB_GADGET
>
> the correct patch would be to turn this into (USB || USB_GADGET) and fix
> the mode selection just like dwc3 is doing.
>
Ah, I see now. Let me prepare a v2 then.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2013-12-20 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 1:20 [PATCH] usb: musb: Remove USB_GADGET driver dependency Ezequiel Garcia
2013-12-20 15:49 ` Felipe Balbi
2013-12-20 17:05 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220170541.GA16652@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).