* [PATCH] usb: musb: Remove USB_GADGET driver dependency
@ 2013-12-20 1:20 Ezequiel Garcia
2013-12-20 15:49 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Ezequiel Garcia @ 2013-12-20 1:20 UTC (permalink / raw)
To: linux-arm-kernel
This USB controller is dual-role, but can also work in host-only mode.
There's no reason to condition the entire driver to USB_GADGET. Fix this by
removing the dependency.
Tested on a Beaglebone black (AM335x) using a regular USB mass storage
device.
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
drivers/usb/musb/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index 57dfc0c..2119370 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -6,7 +6,6 @@
# (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
config USB_MUSB_HDRC
tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
- depends on USB_GADGET
help
Say Y here if your system has a dual role high speed USB
controller based on the Mentor Graphics silicon IP. Then
--
1.8.1.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] usb: musb: Remove USB_GADGET driver dependency
2013-12-20 1:20 [PATCH] usb: musb: Remove USB_GADGET driver dependency Ezequiel Garcia
@ 2013-12-20 15:49 ` Felipe Balbi
2013-12-20 17:05 ` Ezequiel Garcia
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2013-12-20 15:49 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 19, 2013 at 10:20:48PM -0300, Ezequiel Garcia wrote:
> This USB controller is dual-role, but can also work in host-only mode.
> There's no reason to condition the entire driver to USB_GADGET. Fix this by
> removing the dependency.
>
> Tested on a Beaglebone black (AM335x) using a regular USB mass storage
> device.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> drivers/usb/musb/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> index 57dfc0c..2119370 100644
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -6,7 +6,6 @@
> # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
> config USB_MUSB_HDRC
> tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
> - depends on USB_GADGET
the correct patch would be to turn this into (USB || USB_GADGET) and fix
the mode selection just like dwc3 is doing.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131220/cb68bbdc/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] usb: musb: Remove USB_GADGET driver dependency
2013-12-20 15:49 ` Felipe Balbi
@ 2013-12-20 17:05 ` Ezequiel Garcia
0 siblings, 0 replies; 3+ messages in thread
From: Ezequiel Garcia @ 2013-12-20 17:05 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 20, 2013 at 09:49:58AM -0600, Felipe Balbi wrote:
> On Thu, Dec 19, 2013 at 10:20:48PM -0300, Ezequiel Garcia wrote:
> > This USB controller is dual-role, but can also work in host-only mode.
> > There's no reason to condition the entire driver to USB_GADGET. Fix this by
> > removing the dependency.
> >
> > Tested on a Beaglebone black (AM335x) using a regular USB mass storage
> > device.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > ---
> > drivers/usb/musb/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> > index 57dfc0c..2119370 100644
> > --- a/drivers/usb/musb/Kconfig
> > +++ b/drivers/usb/musb/Kconfig
> > @@ -6,7 +6,6 @@
> > # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
> > config USB_MUSB_HDRC
> > tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
> > - depends on USB_GADGET
>
> the correct patch would be to turn this into (USB || USB_GADGET) and fix
> the mode selection just like dwc3 is doing.
>
Ah, I see now. Let me prepare a v2 then.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-20 17:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-20 1:20 [PATCH] usb: musb: Remove USB_GADGET driver dependency Ezequiel Garcia
2013-12-20 15:49 ` Felipe Balbi
2013-12-20 17:05 ` Ezequiel Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).