* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY @ 2013-12-16 0:31 Simon Horman 2013-12-16 13:25 ` Sergei Shtylyov 2013-12-19 23:05 ` Sergei Shtylyov 0 siblings, 2 replies; 10+ messages in thread From: Simon Horman @ 2013-12-16 0:31 UTC (permalink / raw) To: linux-arm-kernel The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm/mach-shmobile/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig index f01e878..670238a 100644 --- a/arch/arm/mach-shmobile/Kconfig +++ b/arch/arm/mach-shmobile/Kconfig @@ -41,6 +41,7 @@ config MACH_GENMAI config MACH_KOELSCH bool "Koelsch board" depends on ARCH_R8A7791 + select MICREL_PHY if SH_ETH config MACH_KZM9D bool "KZM9D board" @@ -269,11 +270,13 @@ config MACH_KOELSCH bool "Koelsch board" depends on ARCH_R8A7791 select USE_OF + select MICREL_PHY if SH_ETH config MACH_KOELSCH_REFERENCE bool "Koelsch board - Reference Device Tree Implementation" depends on ARCH_R8A7791 select USE_OF + select MICREL_PHY if SH_ETH ---help--- Use reference implementation of Koelsch board support which makes use of device tree at the expense -- 1.8.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY 2013-12-16 0:31 [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY Simon Horman @ 2013-12-16 13:25 ` Sergei Shtylyov 2013-12-16 23:31 ` Sergei Shtylyov 2013-12-17 0:30 ` Simon Horman 2013-12-19 23:05 ` Sergei Shtylyov 1 sibling, 2 replies; 10+ messages in thread From: Sergei Shtylyov @ 2013-12-16 13:25 UTC (permalink / raw) To: linux-arm-kernel Hello. On 16-12-2013 4:31, Simon Horman wrote: > The koelsch board uses has an SH ethernet controller which uses a Micrel > phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the > Micrel-specific phy driver rather than relying on the generic phy driver. Frankly speaking, I'm seeing no advantages to doing that. > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Analogous changes are needed for BOCK-W and Lager boards since they all use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the PHY IRQ patches but since no IRQ is generated still, this got delayed... WBR, Sergei ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY 2013-12-16 13:25 ` Sergei Shtylyov @ 2013-12-16 23:31 ` Sergei Shtylyov 2013-12-17 0:31 ` Simon Horman 2013-12-17 0:30 ` Simon Horman 1 sibling, 1 reply; 10+ messages in thread From: Sergei Shtylyov @ 2013-12-16 23:31 UTC (permalink / raw) To: linux-arm-kernel On 12/16/2013 04:25 PM, I wrote: >> The koelsch board uses has an SH ethernet controller which uses a Micrel >> phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the >> Micrel-specific phy driver rather than relying on the generic phy driver. > Frankly speaking, I'm seeing no advantages to doing that. Although wait, Geert has reported the absence of Rx FIFO overflow messages with this PHY driver, IIRC. >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > Analogous changes are needed for BOCK-W and Lager boards since they all > use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the > PHY IRQ patches but since no IRQ is generated still, this got delayed... Only I was going to do it via defconfigs... WBR, Sergei ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY 2013-12-16 23:31 ` Sergei Shtylyov @ 2013-12-17 0:31 ` Simon Horman 2013-12-17 10:10 ` Geert Uytterhoeven 0 siblings, 1 reply; 10+ messages in thread From: Simon Horman @ 2013-12-17 0:31 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 17, 2013 at 02:31:35AM +0300, Sergei Shtylyov wrote: > On 12/16/2013 04:25 PM, I wrote: > > >>The koelsch board uses has an SH ethernet controller which uses a Micrel > >>phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the > >>Micrel-specific phy driver rather than relying on the generic phy driver. > > > Frankly speaking, I'm seeing no advantages to doing that. > > Although wait, Geert has reported the absence of Rx FIFO overflow > messages with this PHY driver, IIRC. > > >>Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > Analogous changes are needed for BOCK-W and Lager boards since they all > >use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the > >PHY IRQ patches but since no IRQ is generated still, this got delayed... > > Only I was going to do it via defconfigs... That was my initial approach too. However I have been convinced that Kconfig is a better way forwards. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY 2013-12-17 0:31 ` Simon Horman @ 2013-12-17 10:10 ` Geert Uytterhoeven 2013-12-18 0:53 ` Simon Horman 0 siblings, 1 reply; 10+ messages in thread From: Geert Uytterhoeven @ 2013-12-17 10:10 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 17, 2013 at 1:31 AM, Simon Horman <horms@verge.net.au> wrote: > On Tue, Dec 17, 2013 at 02:31:35AM +0300, Sergei Shtylyov wrote: >> On 12/16/2013 04:25 PM, I wrote: >> >>The koelsch board uses has an SH ethernet controller which uses a Micrel >> >>phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the >> >>Micrel-specific phy driver rather than relying on the generic phy driver. >> >> > Frankly speaking, I'm seeing no advantages to doing that. >> >> Although wait, Geert has reported the absence of Rx FIFO overflow >> messages with this PHY driver, IIRC. I spoke too soon: apparently the statistical relevance of my reporting was too low. I still see them from time to time, but I think less than before (no numbers available). >> >>Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> >> > Analogous changes are needed for BOCK-W and Lager boards since they all >> >use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the >> >PHY IRQ patches but since no IRQ is generated still, this got delayed... >> >> Only I was going to do it via defconfigs... > > That was my initial approach too. However I have been convinced > that Kconfig is a better way forwards. Kconfig has the advantage that the minimal defconfigs will be smaller, so less churn there. However, it does mean you cannot disable the option anymore via your .config. In this case it's a bit difficult to decide, as sh_eth will work both with and without the specific PHY-driver. If no users want to disable it, I'd go for Kconfig. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY 2013-12-17 10:10 ` Geert Uytterhoeven @ 2013-12-18 0:53 ` Simon Horman 2013-12-19 9:04 ` Simon Horman 0 siblings, 1 reply; 10+ messages in thread From: Simon Horman @ 2013-12-18 0:53 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 17, 2013 at 11:10:15AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 17, 2013 at 1:31 AM, Simon Horman <horms@verge.net.au> wrote: > > On Tue, Dec 17, 2013 at 02:31:35AM +0300, Sergei Shtylyov wrote: > >> On 12/16/2013 04:25 PM, I wrote: > >> >>The koelsch board uses has an SH ethernet controller which uses a Micrel > >> >>phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the > >> >>Micrel-specific phy driver rather than relying on the generic phy driver. > >> > >> > Frankly speaking, I'm seeing no advantages to doing that. > >> > >> Although wait, Geert has reported the absence of Rx FIFO overflow > >> messages with this PHY driver, IIRC. > > I spoke too soon: apparently the statistical relevance of my reporting was > too low. I still see them from time to time, but I think less than before (no > numbers available). > > >> >>Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >> > >> > Analogous changes are needed for BOCK-W and Lager boards since they all > >> >use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the > >> >PHY IRQ patches but since no IRQ is generated still, this got delayed... > >> > >> Only I was going to do it via defconfigs... > > > > That was my initial approach too. However I have been convinced > > that Kconfig is a better way forwards. > > Kconfig has the advantage that the minimal defconfigs will be smaller, so > less churn there. > However, it does mean you cannot disable the option anymore via your .config. > > In this case it's a bit difficult to decide, as sh_eth will work both > with and without > the specific PHY-driver. > > If no users want to disable it, I'd go for Kconfig. It is indeed a tricky choice. But I think we should try going for Kconfig. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY 2013-12-18 0:53 ` Simon Horman @ 2013-12-19 9:04 ` Simon Horman 0 siblings, 0 replies; 10+ messages in thread From: Simon Horman @ 2013-12-19 9:04 UTC (permalink / raw) To: linux-arm-kernel On Wed, Dec 18, 2013 at 09:53:26AM +0900, Simon Horman wrote: > On Tue, Dec 17, 2013 at 11:10:15AM +0100, Geert Uytterhoeven wrote: > > On Tue, Dec 17, 2013 at 1:31 AM, Simon Horman <horms@verge.net.au> wrote: > > > On Tue, Dec 17, 2013 at 02:31:35AM +0300, Sergei Shtylyov wrote: > > >> On 12/16/2013 04:25 PM, I wrote: > > >> >>The koelsch board uses has an SH ethernet controller which uses a Micrel > > >> >>phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the > > >> >>Micrel-specific phy driver rather than relying on the generic phy driver. > > >> > > >> > Frankly speaking, I'm seeing no advantages to doing that. > > >> > > >> Although wait, Geert has reported the absence of Rx FIFO overflow > > >> messages with this PHY driver, IIRC. > > > > I spoke too soon: apparently the statistical relevance of my reporting was > > too low. I still see them from time to time, but I think less than before (no > > numbers available). > > > > >> >>Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > >> > > >> > Analogous changes are needed for BOCK-W and Lager boards since they all > > >> >use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the > > >> >PHY IRQ patches but since no IRQ is generated still, this got delayed... > > >> > > >> Only I was going to do it via defconfigs... > > > > > > That was my initial approach too. However I have been convinced > > > that Kconfig is a better way forwards. > > > > Kconfig has the advantage that the minimal defconfigs will be smaller, so > > less churn there. > > However, it does mean you cannot disable the option anymore via your .config. > > > > In this case it's a bit difficult to decide, as sh_eth will work both > > with and without > > the specific PHY-driver. > > > > If no users want to disable it, I'd go for Kconfig. > > It is indeed a tricky choice. But I think we should try going for Kconfig. I have decided to queue this up. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY 2013-12-16 13:25 ` Sergei Shtylyov 2013-12-16 23:31 ` Sergei Shtylyov @ 2013-12-17 0:30 ` Simon Horman 1 sibling, 0 replies; 10+ messages in thread From: Simon Horman @ 2013-12-17 0:30 UTC (permalink / raw) To: linux-arm-kernel On Mon, Dec 16, 2013 at 05:25:42PM +0400, Sergei Shtylyov wrote: > Hello. > > On 16-12-2013 4:31, Simon Horman wrote: > > >The koelsch board uses has an SH ethernet controller which uses a Micrel > >phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the > >Micrel-specific phy driver rather than relying on the generic phy driver. > > Frankly speaking, I'm seeing no advantages to doing that. I think there is an advantage to using the hardware-specific driver. Even if it make any difference at run-time with the present code. > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Analogous changes are needed for BOCK-W and Lager boards since > they all use the same KSZ8041RNLI PHY chip. I was going to submit > such changes with the PHY IRQ patches but since no IRQ is generated > still, this got delayed... I believe that similar changes are needed for almost all of the shmobile boards. If you would like to handle some or all of them that is quite fine by me. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY 2013-12-16 0:31 [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY Simon Horman 2013-12-16 13:25 ` Sergei Shtylyov @ 2013-12-19 23:05 ` Sergei Shtylyov 2013-12-26 5:30 ` Simon Horman 1 sibling, 1 reply; 10+ messages in thread From: Sergei Shtylyov @ 2013-12-19 23:05 UTC (permalink / raw) To: linux-arm-kernel Hello. On 12/16/2013 03:31 AM, Simon Horman wrote: > The koelsch board uses has an SH ethernet controller which uses a Micrel > phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the > Micrel-specific phy driver rather than relying on the generic phy driver. > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm/mach-shmobile/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig > index f01e878..670238a 100644 > --- a/arch/arm/mach-shmobile/Kconfig > +++ b/arch/arm/mach-shmobile/Kconfig > @@ -41,6 +41,7 @@ config MACH_GENMAI > config MACH_KOELSCH > bool "Koelsch board" > depends on ARCH_R8A7791 > + select MICREL_PHY if SH_ETH > > config MACH_KZM9D > bool "KZM9D board" Simon, did you initially remove that hunk when committing? WBR, Sergei ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY 2013-12-19 23:05 ` Sergei Shtylyov @ 2013-12-26 5:30 ` Simon Horman 0 siblings, 0 replies; 10+ messages in thread From: Simon Horman @ 2013-12-26 5:30 UTC (permalink / raw) To: linux-arm-kernel On Fri, Dec 20, 2013 at 02:05:16AM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/16/2013 03:31 AM, Simon Horman wrote: > > >The koelsch board uses has an SH ethernet controller which uses a Micrel > >phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the > >Micrel-specific phy driver rather than relying on the generic phy driver. > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >--- > > arch/arm/mach-shmobile/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > >diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig > >index f01e878..670238a 100644 > >--- a/arch/arm/mach-shmobile/Kconfig > >+++ b/arch/arm/mach-shmobile/Kconfig > >@@ -41,6 +41,7 @@ config MACH_GENMAI > > config MACH_KOELSCH > > bool "Koelsch board" > > depends on ARCH_R8A7791 > >+ select MICREL_PHY if SH_ETH > > > > config MACH_KZM9D > > bool "KZM9D board" > > Simon, did you initially remove that hunk when committing? Thanks for noticing. I will queue up the following: From: Simon Horman <horms+renesas@verge.net.au> ARM: shmobile: koelsch: Conditionally select MICREL_PHY for Multiplatform The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm/mach-shmobile/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig index a127252..958ccf3d 100644 --- a/arch/arm/mach-shmobile/Kconfig +++ b/arch/arm/mach-shmobile/Kconfig @@ -45,6 +45,7 @@ config MACH_GENMAI config MACH_KOELSCH bool "Koelsch board" depends on ARCH_R8A7791 + select MICREL_PHY if SH_ETH config MACH_KZM9D bool "KZM9D board" -- 1.8.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-12-26 5:30 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-12-16 0:31 [PATCH] ARM: shmobile: koelsch: Conditionally select MICREL_PHY Simon Horman 2013-12-16 13:25 ` Sergei Shtylyov 2013-12-16 23:31 ` Sergei Shtylyov 2013-12-17 0:31 ` Simon Horman 2013-12-17 10:10 ` Geert Uytterhoeven 2013-12-18 0:53 ` Simon Horman 2013-12-19 9:04 ` Simon Horman 2013-12-17 0:30 ` Simon Horman 2013-12-19 23:05 ` Sergei Shtylyov 2013-12-26 5:30 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).