From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] input: sun4i-ts: Add support for temperature sensor
Date: Thu, 26 Dec 2013 09:39:35 +0100 [thread overview]
Message-ID: <20131226093935.28890a14@skate> (raw)
In-Reply-To: <1387923847-1294-3-git-send-email-hdegoede@redhat.com>
Dear Hans de Goede,
On Tue, 24 Dec 2013 23:24:04 +0100, Hans de Goede wrote:
> + of_property_read_u32(np, "ts-attached", &ts_attached);
ts-attached should be a boolean property, and therefore you should use
of_property_read_bool() here.
And in your Device Tree, you should use:
ts-attached;
when a touchscreen is attached. And nothing when no touchscreen is
attached.
Note that this patch is also changing the DT binding, so it should
update the DT binding documentation created in the first patch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-26 8:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 22:24 [PATCH 0/5] input: Add new sun4i-ts driver for Allwinner sunxi SoC's Hans de Goede
2013-12-24 22:24 ` [PATCH 1/5] input: Add new sun4i-ts driver for Allwinner sunxi SoC's rtp controller Hans de Goede
2013-12-25 10:40 ` [lm-sensors] " Guenter Roeck
2013-12-26 8:37 ` Thomas Petazzoni
2013-12-26 22:15 ` Dmitry Torokhov
2013-12-26 22:33 ` Hans de Goede
2013-12-26 23:30 ` Dmitry Torokhov
2013-12-24 22:24 ` [PATCH 2/5] input: sun4i-ts: Add support for temperature sensor Hans de Goede
2013-12-25 10:37 ` [lm-sensors] " Guenter Roeck
2013-12-25 10:54 ` [linux-sunxi] " Hans de Goede
2013-12-26 22:19 ` Dmitry Torokhov
2013-12-26 8:39 ` Thomas Petazzoni [this message]
2013-12-24 22:24 ` [PATCH 3/5] ARM: dts: sun4i: Add rtp controller node Hans de Goede
2013-12-24 22:24 ` [PATCH 4/5] ARM: dts: sun5i: " Hans de Goede
2013-12-24 22:24 ` [PATCH 5/5] ARM: dts: sun7i: " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226093935.28890a14@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox