linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: mvebu: move Armada 370/XP specific definitions to armada-370-xp.h
Date: Thu, 26 Dec 2013 17:18:06 +0100	[thread overview]
Message-ID: <20131226161806.GC19323@lunn.ch> (raw)
In-Reply-To: <20131226170454.79529766@skate>

On Thu, Dec 26, 2013 at 05:04:54PM +0100, Thomas Petazzoni wrote:
> Dear Andrew Lunn,
> 
> On Thu, 26 Dec 2013 17:00:48 +0100, Andrew Lunn wrote:
> 
> > Just a question. How much of armada-370-xp.h is specific to just one
> > of these? Things like all the SMP support is XP only. Does it make
> > sense to have armada-370.h, armada-xp.h, then a shared
> > armada-370-xp.h, followed by common.h?
> > 
> > As more SoCs move in, having a clean well defined structure is going
> > to help with the merging.
> 
> As it is today, none of the contents of armada-370-xp.h are useful for
> Armada 370. However, the "main" file is also named armada-370-xp.c and
> handles both SoC, so it made sense to have a file named armada-370-xp.h
> as well.

Hi Thomas

So thinking about dove, kirkwood, this new SoC, all living in mvebu,
should we have a board-dt.c file which all SoCs share, and then one
.c/.h pair of files per SoC? I'm saying this without looking at the
actual content, so i've no idea is this is actually possible. I guess
we need to do something like this sometime, but does it need to be
now?

	Andrew

  reply	other threads:[~2013-12-26 16:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-26  8:20 [PATCH 0/2] ARM: mvebu: additional cleanups Thomas Petazzoni
2013-12-26  8:20 ` [PATCH 1/2] ARM: mvebu: remove prototypes of non-existing functions from common.h Thomas Petazzoni
2013-12-26  8:20 ` [PATCH 2/2] ARM: mvebu: move Armada 370/XP specific definitions to armada-370-xp.h Thomas Petazzoni
2013-12-26 16:00   ` Andrew Lunn
2013-12-26 16:04     ` Thomas Petazzoni
2013-12-26 16:18       ` Andrew Lunn [this message]
2013-12-26 16:49         ` Thomas Petazzoni
2013-12-27 17:06           ` Jason Cooper
2013-12-27 18:12 ` [PATCH 0/2] ARM: mvebu: additional cleanups Jason Cooper
  -- strict thread matches above, loose matches on Subject: below --
2013-12-26 14:22 [PATCH 0/2] ARM: mvebu: minor improvements Thomas Petazzoni
2013-12-26 14:22 ` [PATCH 2/2] ARM: mvebu: move Armada 370/XP specific definitions to armada-370-xp.h Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131226161806.GC19323@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).