public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs
Date: Mon, 30 Dec 2013 16:16:26 +0100	[thread overview]
Message-ID: <20131230151626.GT3144@lukather> (raw)
In-Reply-To: <1388373949-28506-5-git-send-email-wens@csie.org>

Hi Chen-Yu,

On Mon, Dec 30, 2013 at 11:25:49AM +0800, Chen-Yu Tsai wrote:
> This patch adds the clock output pin options on the A20.
> The 2 pins can output a configurable clock to be used by
> external modules. This is used on the CubieTruck, to supply
> a 32768 Hz low power clock to the onboard Wifi+BT module.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  arch/arm/boot/dts/sun7i-a20.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index f255a49..7b46ce5 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -416,6 +416,20 @@
>  				allwinner,drive = <0>;
>  				allwinner,pull = <0>;
>  			};
> +
> +			clk_out_a_pins: clk_out_a at 0 {
> +				allwinner,pins = "PI12";
> +				allwinner,function = "clk_out_a";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};
> +
> +			clk_out_b_pins: clk_out_b at 0 {
> +				allwinner,pins = "PI13";
> +				allwinner,function = "clk_out_b";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};

The labels should be clk_out_[ab]_pins_a. That way, if another muxing
pops up for this clock, we will just need to add the new node, without
modifying the one you add just there.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131230/19b5534f/attachment.sig>

      reply	other threads:[~2013-12-30 15:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30  3:25 [PATCH v2 0/4] clk: sunxi: add A20 external output clock support Chen-Yu Tsai
2013-12-30  3:25 ` [PATCH v2 1/4] clk: sunxi: Allwinner A20 " Chen-Yu Tsai
2013-12-30  3:25 ` [PATCH v2 2/4] ARM: dts: sun7i: external clock outputs Chen-Yu Tsai
2013-12-30 15:25   ` Maxime Ripard
2013-12-31  2:12     ` Chen-Yu Tsai
2014-01-01 23:12       ` Maxime Ripard
2013-12-30  3:25 ` [PATCH v2 3/4] pinctrl: sunxi: Add Allwinner A20 clock output pin functions Chen-Yu Tsai
2013-12-30 15:11   ` Maxime Ripard
2014-01-08  9:47   ` Linus Walleij
2013-12-30  3:25 ` [PATCH v2 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs Chen-Yu Tsai
2013-12-30 15:16   ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131230151626.GT3144@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox