From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00AC2C27C55 for ; Mon, 10 Jun 2024 10:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/liJZNvFP0LF7+smdcvINavitqDgEjkkctRJ1d7ZoEM=; b=q5iBNC0L3QxD8/ ZGgzofVdNsPQV6ptYQQ8WYR7MFB2ODP5I2pimAa2+kNsP6oNou4ViIsArYKOjnMWzE7BUVp3Jjszd HFv1R+bO0th4QT57H7w62B3GEc7FLVwTGSgCnJu8S+D2iXLCTGC9EglT5R5J8KPoau7pBZqtnhQNf GNFVuebOpD8ObcTBF7rzkcJCPThS9wjPjGUSIC9gjnlMr+HpGZzKoMVom/MtopI7jHrd3OHQeLzMk s1+ASXk/+UKtc22Lf8reMqe3IFOVok+CreuD5H898TBsTXKXsTtcWtGKjVly+rX/v2Y4x5Z9K79x/ Ls/oFK0ChqL5sVyBB8Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGcVp-00000004h0Z-221J; Mon, 10 Jun 2024 10:44:30 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGcVb-00000004goE-0gOB for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 10:44:18 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D39AB883F2; Mon, 10 Jun 2024 12:44:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1718016247; bh=DYg6tL7HTuHnmwDK8wj/mmR4QXzEn5dAlWnruAHXPi8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HdUxmK4v1UYivallEA9IKBrXygjcQS3ygkoyqmVx291CNwAXywRP9eCnB7J+T8BQk 4uE+ZV65FzEgxmpg8HE34onFYJEfnNa5Nms6TLUrzt8sS1xqroVSwVdJqk6zQK1gEb P7NVyj4n7EWt1V8HFSYxsYusJuSiVBRvpGTN3++sAn764fl9sp+Yf5Gp3RIXGqFkXp V2uj1ZdqGYIC4WWZGB7YDAO8niXjJVInmPEiixUXzvfUxJtPcymddHZauqDvXjuqxB 1qD94BLQR/PPaDU8rdWkn0Ah9FTU7pUjCwuFbhe8WMbzX4E65TbxQJG9xeE/M6p7Z4 w09oYPDyzc1qg== Message-ID: <20139233-4e95-4fe5-84ca-734ee866afca@denx.de> Date: Mon, 10 Jun 2024 12:39:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next,PATCH v6 7/8] net: stmmac: dwmac-stm32: Mask support for PMCR configuration To: Christophe Roullier , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240610071459.287500-1-christophe.roullier@foss.st.com> <20240610071459.287500-8-christophe.roullier@foss.st.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20240610071459.287500-8-christophe.roullier@foss.st.com> X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_034415_412223_D09DB87C X-CRM114-Status: GOOD ( 10.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/10/24 9:14 AM, Christophe Roullier wrote: [...] > static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat) > @@ -303,7 +307,7 @@ static int stm32mcu_set_mode(struct plat_stmmacenet_data *plat_dat) > dev_dbg(dwmac->dev, "Mode %s", phy_modes(plat_dat->mac_interface)); > > return regmap_update_bits(dwmac->regmap, reg, > - dwmac->ops->syscfg_eth_mask, val << 23); > + SYSCFG_MCU_ETH_MASK, val << 23); > } > > static void stm32_dwmac_clk_disable(struct stm32_dwmac *dwmac, bool suspend) > @@ -348,8 +352,15 @@ static int stm32_dwmac_parse_data(struct stm32_dwmac *dwmac, > return PTR_ERR(dwmac->regmap); > > err = of_property_read_u32_index(np, "st,syscon", 1, &dwmac->mode_reg); > - if (err) > + if (err) { > dev_err(dev, "Can't get sysconfig mode offset (%d)\n", err); > + return err; > + } > + > + dwmac->mode_mask = SYSCFG_MP1_ETH_MASK; > + err = of_property_read_u32_index(np, "st,syscon", 2, &dwmac->mode_mask); > + if (err) > + dev_dbg(dev, "Warning sysconfig register mask not set\n"); Isn't this an error , so dev_err() ? Include the err variable in the error message, see the dev_err() above for an example. That way the log already contains useful information (the error code) that can be used to narrow down the problem. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel