From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] spi: clps711x: Driver refactor
Date: Thu, 2 Jan 2014 18:25:49 +0000 [thread overview]
Message-ID: <20140102182549.GF31886@sirena.org.uk> (raw)
In-Reply-To: <201401021846.23488.arnd@arndb.de>
On Thu, Jan 02, 2014 at 06:46:23PM +0100, Arnd Bergmann wrote:
> I definitely agree with what you say, but please note that Alexander is
> the only person who ever sends clps711x patches, so there is not much
> hope of collaboration. I also suspect he's the only one who would
There's stuff been going in from the people who do generic cleanups and
updates.
> suffer from accidental breakage, especially since the existing driver
> is not used anywhere upstream (no instance of platform data, and no
> DT support).
Right. On the other hand I really don't want to get into setting bad
precedents that people then use when they complain that I actually want
to review their code, that's just going to be more miserable in the long
run.
There were also some things in there that I really did want to review
properly but I wasn't entirely sure what they were actually supposed to
be doing. Getting things split up with better changelogs will make that
review much more tractable, it might even be immediately obvious what is
going on.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140102/0da08763/attachment-0001.sig>
next prev parent reply other threads:[~2014-01-02 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 6:09 [PATCH 1/2] spi: clps711x: Driver refactor Alexander Shiyan
2014-01-01 13:23 ` Mark Brown
2014-01-01 13:44 ` Alexander Shiyan
2014-01-01 15:07 ` Mark Brown
2014-01-02 17:46 ` Arnd Bergmann
2014-01-02 18:20 ` Alexander Shiyan
2014-01-02 18:25 ` Mark Brown [this message]
2014-01-02 19:03 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2016-07-06 14:53 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140102182549.GF31886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).