linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] i2c: s3c2410 : Add polling mode support
Date: Fri, 3 Jan 2014 17:10:12 +0100	[thread overview]
Message-ID: <20140103161012.GH7132@katana> (raw)
In-Reply-To: <1384168820-2986-1-git-send-email-yuvaraj.cd@samsung.com>

Hi,

On Mon, Nov 11, 2013 at 04:50:20PM +0530, Yuvaraj Kumar C D wrote:
> From: Vasanth Ananthan <vasanthananthan@gmail.com>
> 
> This patch adds polling mode support for i2c-s3c2410 driver.The
> SATA PHY controller's CMU and TRSV block's are of I2C register
> map in exynos5250.These blocks can be configured using i2c.
> 
> But i2c controller instance on which these block's sits lacks an
> interrupt line.Also the current i2c-s3c2410 driver is only interrupt
> driven, thus a polling mode support is required in the driver for
> supporting this controller. This patch adds this support to the driver.
> 
> Changes from V1:
> 	1.Changed the is_ack() to have even period b/w polls and
> 	  used usleep_range() instead of udelay().

Mileages vary, but I'd like to see revision changes after the "---".

>  	ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
> -			       dev_name(&pdev->dev), i2c);
> +				dev_name(&pdev->dev), i2c);

Unrelated change.

Rest looks good, so I'll fix up the things for you and apply to
for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140103/ee197629/attachment.sig>

  parent reply	other threads:[~2014-01-03 16:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 11:20 [PATCH V2] i2c: s3c2410 : Add polling mode support Yuvaraj Kumar C D
2013-11-22  6:02 ` Yuvaraj Kumar
2013-12-13  9:21   ` Yuvaraj Kumar
2014-01-02  5:01     ` Yuvaraj Cd
2014-01-03 16:10 ` Wolfram Sang [this message]
2014-01-06  4:00   ` Yuvaraj Cd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140103161012.GH7132@katana \
    --to=wsa@the-dreams.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).