linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: mvebu: Add support to get the ID and the revision of a SoC
Date: Fri, 3 Jan 2014 17:41:08 +0100	[thread overview]
Message-ID: <20140103164108.GA23714@lunn.ch> (raw)
In-Reply-To: <52C6D3A8.4010801@free-electrons.com>

> >> Hi Gregory
> >>
> >> I'm away from my hardware at the moment. 
> >>
> >> Does this work when all the PCIe ports have status = "disabled";? We
> >> have many kirkwood devices in NAS boxes which don't use PCIe, so all
> >> the ports are disabled. But they still exist in the SoC, so we can
> >> read the IDs from them. I just don't know if of_get_next_child() will
> >> only return enabled children?
> > 
> > There is a function named of_get_next_available_child, so I assumed that
> > of_get_next_child() will return all the children. But I can test it to
> > be sure of it.
> > 
> 
> I have just removed all the PCIe part in the
> armada-xp-openblocks-ax3-4.dts file (PCie is disable by default in the
> dtsi file) and it worled as expected! :)

Great, thanks for testing.
 
> by the way waht do you think of adding this line in at the end of the
> mvebu_soc_id_init() function:
> 
> pr_info("MVEBU SoC ID=0x%X, Rev=0x%X\n", soc_dev_id, soc_rev);

Kirkwood prints actual strings, not numbers. More readable.
 
> Also keep in mind that currently you can't use it for kirkwood because
> the build of the file depend on CONFIG_ARCH_MVEBU. But as kirkwood
> will soon joined the mach-mvebu directory, it won't be a problem then.

I think it is possible to do ../mach-mvebu/soc_id.o sort of thing in
the Makefile. Ugly, but might work until we move.

    Andrew

  reply	other threads:[~2014-01-03 16:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-03  9:59 [PATCH v2 0/2] Fix i2c bus hang on A0 version of the Armada XP SoCs Gregory CLEMENT
2014-01-03  9:59 ` [PATCH v2 1/2] ARM: mvebu: Add support to get the ID and the revision of a SoC Gregory CLEMENT
2014-01-03 14:47   ` Andrew Lunn
2014-01-03 14:51     ` Gregory CLEMENT
2014-01-03 15:13       ` Gregory CLEMENT
2014-01-03 16:41         ` Andrew Lunn [this message]
2014-01-03 19:30           ` Gregory CLEMENT
2014-01-03 18:48   ` Thomas Petazzoni
2014-01-03 19:25     ` Gregory CLEMENT
2014-01-03 18:59   ` Jason Gunthorpe
2014-01-03 19:35     ` Gregory CLEMENT
2014-01-05 14:25   ` Arnd Bergmann
2014-01-05 15:40     ` Andrew Lunn
2014-01-05 17:27       ` Jason Gunthorpe
2014-01-05 17:37         ` Sebastian Hesselbarth
2014-01-05 23:07           ` Jason Gunthorpe
2014-01-05 23:12             ` Sebastian Hesselbarth
2014-01-05 23:40               ` Jason Gunthorpe
2014-01-06  0:05                 ` Sebastian Hesselbarth
2014-01-06  0:17                   ` Andrew Lunn
2014-01-06  9:55                     ` Gregory CLEMENT
2014-01-06 10:10                       ` Gregory CLEMENT
2014-01-05 19:17       ` Arnd Bergmann
2014-01-05 23:51         ` Andrew Lunn
2014-01-06 15:37           ` Arnd Bergmann
2014-01-06 16:24             ` Andrew Lunn
2014-01-07 14:41               ` Arnd Bergmann
2014-01-06 10:28     ` Gregory CLEMENT
2014-01-03  9:59 ` [PATCH v2 2/2] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs Gregory CLEMENT
2014-01-03 12:20   ` Gregory CLEMENT
2014-01-03 18:49   ` Thomas Petazzoni
2014-01-03 19:31     ` Gregory CLEMENT
2014-01-05 14:33   ` Arnd Bergmann
2014-01-06  9:09     ` Gregory CLEMENT
2014-01-07  9:03       ` Arnd Bergmann
2014-01-07 13:17         ` Gregory CLEMENT
2014-01-07 20:50           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140103164108.GA23714@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).