From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: Explicitly pass the active level of the PHY reset
Date: Fri, 3 Jan 2014 21:47:02 -0800 [thread overview]
Message-ID: <20140104054702.GA6243@quad.lixom.net> (raw)
In-Reply-To: <20140103120712.GE25079@S2101-09.ap.freescale.net>
On Fri, Jan 03, 2014 at 08:07:14PM +0800, Shawn Guo wrote:
> On Fri, Jan 03, 2014 at 09:55:56AM -0200, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Since commit 7a399e3a2e (fec: Do not assume that PHY reset is active low), we no
> > longer assume that the PHY reset is active low.
> >
> > Now we need to retrieve this information from the device tree instead.
> >
> > Passing '0' as the phy-reset-gpios means 'active high' according to the
> > definition from include/dt-bindings/gpio/gpio.h:
> >
> > #define GPIO_ACTIVE_HIGH 0
> > #define GPIO_ACTIVE_LOW 1
> >
> > , so in order to keep things working as before we need to explicitly pass
> > GPIO_ACTIVE_LOW as the flag.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
>
Applied to fixes. Thanks.
-Olof
next prev parent reply other threads:[~2014-01-04 5:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 11:55 [PATCH] ARM: imx: Explicitly pass the active level of the PHY reset Fabio Estevam
2014-01-03 12:07 ` Shawn Guo
2014-01-04 5:47 ` Olof Johansson [this message]
2014-01-05 17:29 ` Olof Johansson
2014-01-06 2:24 ` Shawn Guo
2014-01-06 2:43 ` Olof Johansson
2014-01-06 11:14 ` Russell King - ARM Linux
2014-01-06 12:43 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2014-01-03 2:14 Fabio Estevam
2014-01-03 3:22 ` Shawn Guo
2014-01-03 3:28 ` Fabio Estevam
2014-01-03 4:15 ` Shawn Guo
2014-01-03 11:21 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140104054702.GA6243@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).