linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: kconfig: select HAVE_EFFICIENT_UNALIGNED_ACCESS for CPUv6+ && MMU
Date: Mon, 6 Jan 2014 14:58:30 +0000	[thread overview]
Message-ID: <20140106145829.GD10449@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <alpine.LFD.2.10.1312171528130.7480@knanqh.ubzr>

Hi Nicolas,

On Tue, Dec 17, 2013 at 08:34:18PM +0000, Nicolas Pitre wrote:
> On Tue, 17 Dec 2013, Will Deacon wrote:
> 
> > Modern ARM CPUs can perform efficient unaligned memory accesses in
> > hardware and this feature is relied up on by code such as the dcache
> > word-at-a-time name hashing.
> > 
> > This patch selects HAVE_EFFICIENT_UNALIGNED_ACCESS for these cores and
> > reworks the kconfig select logic for DCACHE_WORD_ACCESS to use the new
> > symbol.
> > 
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> 
> This symbol could be used in some more places too.  For example this 
> would make the code a bit clearer:

Well spotted.

> diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h
> index 72abdc541f..12c3a5decc 100644
> --- a/arch/arm/include/asm/uaccess.h
> +++ b/arch/arm/include/asm/uaccess.h
> @@ -19,7 +19,7 @@
>  #include <asm/unified.h>
>  #include <asm/compiler.h>
>  
> -#if __LINUX_ARM_ARCH__ < 6
> +#ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>  #include <asm-generic/uaccess-unaligned.h>
>  #else
>  #define __get_user_unaligned __get_user

The original patch is now queued, so we can add this hunk as a follow-up
cleanup patch. I've got you as the author, but can I add your S-o-B please?

Cheers,

Will

  reply	other threads:[~2014-01-06 14:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 12:16 [PATCH 1/2] ARM: dcache: select DCACHE_WORD_ACCESS for big-endian CPUs Will Deacon
2013-12-17 12:16 ` [PATCH 2/2] ARM: kconfig: select HAVE_EFFICIENT_UNALIGNED_ACCESS for CPUv6+ && MMU Will Deacon
2013-12-17 20:34   ` Nicolas Pitre
2014-01-06 14:58     ` Will Deacon [this message]
2014-01-06 15:17       ` Nicolas Pitre
2013-12-17 20:27 ` [PATCH 1/2] ARM: dcache: select DCACHE_WORD_ACCESS for big-endian CPUs Nicolas Pitre
2014-01-06 15:45 ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140106145829.GD10449@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).