public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/8] clk: sunxi: add clock-output-names dt property support
Date: Tue, 7 Jan 2014 23:14:30 +0100	[thread overview]
Message-ID: <20140107221430.GE3103@lukather> (raw)
In-Reply-To: <1388987892-23733-2-git-send-email-wens@csie.org>

Hi Chen-Yu,

On Mon, Jan 06, 2014 at 01:58:05PM +0800, Chen-Yu Tsai wrote:
> sunxi clock drivers use dt node name as clock name, but clock
> nodes should be named clk at X, so the names would be the same.
> Let the drivers read clock names from dt clock-output-names
> property.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/clk/sunxi/clk-sunxi.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 19d9e9e..14a3774 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -53,6 +53,8 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>  	if (of_property_read_u32(node, "clock-frequency", &rate))
>  		return;
>  
> +	of_property_read_string(node, "clock-output-names", &clk_name);
> +
>  	/* set up gate and fixed rate properties */
>  	gate->reg = of_iomap(node, 0);
>  	gate->bit_idx = SUNXI_OSC24M_GATE;
> @@ -595,6 +597,8 @@ static void __init sunxi_mux_clk_setup(struct device_node *node,
>  	       (parents[i] = of_clk_get_parent_name(node, i)) != NULL)
>  		i++;
>  
> +	of_property_read_string(node, "clock-output-names", &clk_name);
> +
>  	clk = clk_register_mux(NULL, clk_name, parents, i,
>  			       CLK_SET_RATE_NO_REPARENT, reg,
>  			       data->shift, SUNXI_MUX_GATE_WIDTH,
> @@ -654,6 +658,8 @@ static void __init sunxi_divider_clk_setup(struct device_node *node,
>  
>  	clk_parent = of_clk_get_parent_name(node, 0);
>  
> +	of_property_read_string(node, "clock-output-names", &clk_name);
> +
>  	clk = clk_register_divider(NULL, clk_name, clk_parent, 0,
>  				   reg, data->shift, data->width,
>  				   data->pow ? CLK_DIVIDER_POWER_OF_TWO : 0,
> -- 
> 1.8.5.2
> 

Please document this in Documentation/devicetree/bindings.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140107/36a0c0f1/attachment.sig>

  reply	other threads:[~2014-01-07 22:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06  5:58 [PATCH v2 0/8] arm: sunxi: rename DT clock node names to clk@N Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 1/8] clk: sunxi: add clock-output-names dt property support Chen-Yu Tsai
2014-01-07 22:14   ` Maxime Ripard [this message]
2014-01-08  1:44     ` [linux-sunxi] " Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 2/8] clk: sunxi: choose correct name for multiple output factor clocks Chen-Yu Tsai
2014-01-07 22:16   ` Maxime Ripard
2014-01-07 22:41     ` Maxime Ripard
2014-01-06  5:58 ` [PATCH v2 3/8] clk: sunxi: get divs parent clock name from parent factor clock Chen-Yu Tsai
2014-01-07 22:17   ` Maxime Ripard
2014-01-06  5:58 ` [PATCH v2 4/8] arm: dts: sun4i: rename clock node names to clk@N Chen-Yu Tsai
2014-01-07 22:38   ` Maxime Ripard
2014-01-08  1:38     ` Chen-Yu Tsai
2014-01-09  8:53       ` Maxime Ripard
2014-01-09 15:47         ` Emilio López
2014-01-09 16:02           ` [linux-sunxi] " Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 5/8] arm: dts: sun5i: " Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 6/8] arm: dts: sun6i: " Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 7/8] arm: dts: sun7i: " Chen-Yu Tsai
2014-01-06  5:58 ` [PATCH v2 8/8] arm: sun7i: cubietruck: Enable the i2c controllers Chen-Yu Tsai
2014-01-07 22:40   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140107221430.GE3103@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox