From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs
Date: Wed, 8 Jan 2014 06:17:21 +0800 [thread overview]
Message-ID: <20140108061721.20f09871@skate> (raw)
In-Reply-To: <1389112504-9931-4-git-send-email-gregory.clement@free-electrons.com>
Dear Gregory CLEMENT,
On Tue, 7 Jan 2014 17:35:04 +0100, Gregory CLEMENT wrote:
> if (of_device_is_compatible(np, "marvell,mv78230-i2c")) {
> - drv_data->offload_enabled = true;
> drv_data->errata_delay = true;
> +
> + if (!of_find_property(np, "offload-broken", NULL))
> + drv_data->offload_enabled = true;
> }
I think of_property_read_bool() is more appropriate than
of_find_property() in this situation, because offload-broken is indeed
a boolean property.
Something like:
drv_data->offload_enable = !of_property_read_bool(np, "offload-broken");
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-01-07 22:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 16:35 [PATCH v4 0/3] Fix i2c bus hang on A0 version of the Armada XP SoCs Gregory CLEMENT
2014-01-07 16:35 ` [PATCH v4 1/3] ARM: mvebu: Add support to get the ID and the revision of a SoC Gregory CLEMENT
2014-01-08 12:55 ` Arnd Bergmann
2014-01-08 14:16 ` Gregory CLEMENT
2014-01-07 16:35 ` [PATCH v4 2/3] ARM: mvebu: Add quirk for i2c Gregory CLEMENT
2014-01-07 18:38 ` Jason Gunthorpe
2014-01-07 23:06 ` Wolfram Sang
2014-01-08 10:15 ` Gregory CLEMENT
2014-01-08 11:29 ` Wolfram Sang
2014-01-08 13:03 ` Gregory CLEMENT
2014-01-08 13:39 ` Wolfram Sang
2014-01-08 13:45 ` Arnd Bergmann
2014-01-08 14:10 ` Gregory CLEMENT
2014-01-08 14:07 ` Gregory CLEMENT
2014-01-09 14:39 ` Gregory CLEMENT
2014-01-08 12:52 ` Arnd Bergmann
2014-01-08 13:42 ` Gregory CLEMENT
2014-01-08 13:44 ` Arnd Bergmann
2014-01-07 16:35 ` [PATCH v4 3/3] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs Gregory CLEMENT
2014-01-07 22:17 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108061721.20f09871@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).