linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs
Date: Wed, 8 Jan 2014 16:21:39 +0100	[thread overview]
Message-ID: <20140108152139.GB15182@katana> (raw)
In-Reply-To: <1389193589-18485-4-git-send-email-gregory.clement@free-electrons.com>

On Wed, Jan 08, 2014 at 04:06:28PM +0100, Gregory CLEMENT wrote:
> The first variants of Armada XP SoCs (A0 stepping) have issues related
> to the i2c controller which prevent to use the offload mechanism and
> lead to a kernel hang during boot.
> 
> The commit introduces a new the compatible string
> marvell,mv78230-a0-i2c for the i2c controller. When this compatible
> string is used the driver disables the offload mechanism and the
> kernel no more hangs on these SoCs.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Reported-by: Andrew Lunn <andrew@lunn.ch>
> Cc: stable at vger.kernel.org
> ---
>  drivers/i2c/busses/i2c-mv64xxx.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 8be7e42aa4de..f424c0f89946 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -692,6 +692,10 @@ static const struct of_device_id mv64xxx_i2c_of_match_table[] = {
>  	{ .compatible = "allwinner,sun4i-i2c", .data = &mv64xxx_i2c_regs_sun4i},
>  	{ .compatible = "marvell,mv64xxx-i2c", .data = &mv64xxx_i2c_regs_mv64xxx},
>  	{ .compatible = "marvell,mv78230-i2c", .data = &mv64xxx_i2c_regs_mv64xxx},
> +	{
> +		.compatible = "marvell,mv78230-a0-i2c",
> +		.data = &mv64xxx_i2c_regs_mv64xxx
> +	},

I think a oneliner entry like the entries above is easier to read, but
that is very minor...

Acked-by: Wolfram Sang <wsa@the-dreams.de>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140108/5d478cfa/attachment.sig>

  reply	other threads:[~2014-01-08 15:21 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 15:06 [PATCH v5 0/4] Fix i2c bus hang on A0 version of the Armada XP SoCs Gregory CLEMENT
2014-01-08 15:06 ` [PATCH v5 1/4] ARM: mvebu: Add support to get the ID and the revision of a SoC Gregory CLEMENT
2014-01-08 15:06 ` [PATCH v5 2/4] ARM: mvebu: Add quirk for i2c for the OpenBlocks AX3-4 board Gregory CLEMENT
2014-01-08 15:22   ` Wolfram Sang
2014-01-08 15:28     ` Gregory CLEMENT
2014-01-10 18:22   ` Jason Cooper
2014-01-10 19:05     ` Jason Gunthorpe
2014-01-10 19:45       ` Jason Cooper
2014-01-10 20:08         ` Jason Cooper
2014-01-10 20:12           ` Gregory CLEMENT
2014-01-10 21:14             ` Jason Cooper
2014-01-10 21:21               ` Gregory CLEMENT
2014-01-10 21:37                 ` Jason Cooper
2014-01-10 21:52                   ` Gregory CLEMENT
2014-01-13 15:02                     ` Gregory CLEMENT
2014-01-10 20:09         ` Gregory CLEMENT
2014-01-10 21:11           ` Jason Cooper
2014-01-10 21:06         ` Jason Gunthorpe
2014-01-10 21:19           ` Jason Cooper
2014-01-08 15:06 ` [PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs Gregory CLEMENT
2014-01-08 15:21   ` Wolfram Sang [this message]
2014-01-08 15:26     ` Gregory CLEMENT
2014-01-08 15:28       ` Arnd Bergmann
2014-01-08 15:28       ` Wolfram Sang
2014-01-08 15:06 ` [PATCH v5 4/4] i2c: mv64xxx: Document the newly introduced Armada XP A0 compatible Gregory CLEMENT
2014-01-10 21:55   ` Jason Cooper
2014-01-10 23:04     ` Gregory CLEMENT
2014-01-08 15:13 ` [PATCH v5 0/4] Fix i2c bus hang on A0 version of the Armada XP SoCs Arnd Bergmann
2014-01-08 16:46 ` Gregory CLEMENT
2014-01-14  2:14 ` Jason Cooper
2014-01-14  8:46   ` Gregory CLEMENT
2014-01-20 11:20     ` Gregory CLEMENT
2014-01-20 14:44       ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140108152139.GB15182@katana \
    --to=wsa@the-dreams.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).