From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] ARM: tegra: Add efuse bindings
Date: Wed, 8 Jan 2014 21:09:48 +0100 [thread overview]
Message-ID: <20140108200946.GE1298@ulmo.nvidia.com> (raw)
In-Reply-To: <52CD9DFB.9010007@wwwdotorg.org>
On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote:
> On 01/08/2014 06:39 AM, Thierry Reding wrote:
> > On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote:
> >> On 12/24/2013 06:32 AM, Peter De Schrijver wrote:
> > [...]
> >>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> >>
> >>> + efuse at 7000F800 {
> >>
> >> "fuse" might be a better node name; "efuse" is presumably the name of
> >> the instance, not the type of object.
> >
> > There's another occurrence I noticed recently where we haven't followed
> > that rule. The PMIC node on Venice2 for instance is called as3722.
> > Perhaps that should also be renamed.
>
> Yes, we should fix that. Care to send a patch?
Ugh... I've just been going through some of the other DTS files and see
that quite a lot of other places aren't following this rule either. The
Beaver DTS has things like:
rt5640: rt5640 at 1c {
...
};
which I guess "should have been"
rt5640: codec at 1c { /* or even audio-codec at 1c */
...
};
and
pmic: tps65911 at 2d {
...
};
>
which would be another candidate for pmic at 2d.
Perhaps it isn't worth fixing them all up after all?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140108/a8bf636c/attachment.sig>
next prev parent reply other threads:[~2014-01-08 20:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 13:32 [PATCH v2 0/6] efuse driver for Tegra Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel Peter De Schrijver
2014-01-06 20:07 ` Stephen Warren
2014-01-07 12:54 ` Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 2/6] misc: fuse: Add efuse driver for Tegra Peter De Schrijver
2014-01-06 20:32 ` Stephen Warren
2014-01-07 14:05 ` Peter De Schrijver
2014-01-07 20:41 ` Stephen Warren
2013-12-24 13:32 ` [PATCH v2 3/6] ARM: tegra: Add efuse bindings Peter De Schrijver
2014-01-06 20:40 ` Stephen Warren
2014-01-08 13:39 ` Thierry Reding
2014-01-08 18:50 ` Stephen Warren
2014-01-08 20:05 ` Thierry Reding
2014-01-08 20:09 ` Thierry Reding [this message]
2014-01-08 22:41 ` Stephen Warren
2014-01-09 12:40 ` Thierry Reding
2013-12-24 13:32 ` [PATCH v2 4/6] ARM: tegra: rework fuse.c Peter De Schrijver
2014-01-03 11:19 ` Alexandre Courbot
2014-01-06 20:50 ` Stephen Warren
2014-01-07 14:10 ` Peter De Schrijver
2014-01-07 20:47 ` Stephen Warren
2014-01-08 8:31 ` Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 5/6] ARM: Tegra: remove speedo files Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 6/6] misc: enable fuse drivers Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108200946.GE1298@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).