From: Guangyu.Chen@freescale.com (Nicolin Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx6q: Add missing esai_ahb clock to current clock tree
Date: Thu, 9 Jan 2014 11:49:41 +0800 [thread overview]
Message-ID: <20140109034940.GA14480@MrMyself> (raw)
In-Reply-To: <20140109035810.GB21717@S2101-09.ap.freescale.net>
On Thu, Jan 09, 2014 at 11:58:12AM +0800, Shawn Guo wrote:
> > static struct clk *clk[clk_max];
> > @@ -355,6 +355,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
> > clk[ecspi5] = imx_clk_gate2("ecspi5", "ecspi_root", base + 0x6c, 8);
> > clk[enet] = imx_clk_gate2("enet", "ipg", base + 0x6c, 10);
> > clk[esai] = imx_clk_gate2("esai", "esai_podf", base + 0x6c, 16);
> > + clk[esai_ahb] = imx_clk_gate2("esai_ahb", "ahb", base + 0x6c, 16);
>
> Hmm, having two clocks operating on the same gate bit will get us
> problem in clock disabling. Clock enabling is fine, since either
> one who calls clk_enable() first will just set the gate bit. But in
> case that clk_enable() is called on both clocks, and then when either
> clock calls clk_disable(), the gate bit will be cleared and thus breaks
> the other one that might still be in use.
Understood. But how could we handle this situation? The only way I can figure
out is to make sure the driver open/close them at the same time, it's not a
perfect way though.
Nicolin
next prev parent reply other threads:[~2014-01-09 3:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 3:04 [PATCH] ARM: imx6q: Add missing esai_ahb clock to current clock tree Nicolin Chen
2014-01-09 3:58 ` Shawn Guo
2014-01-09 3:49 ` Nicolin Chen [this message]
2014-01-09 6:57 ` Shawn Guo
2014-01-09 7:41 ` Nicolin Chen
2014-01-09 7:58 ` Sascha Hauer
2014-01-09 7:51 ` Nicolin Chen
2014-01-09 7:55 ` Sascha Hauer
2014-01-09 14:57 ` Gerhard Sittig
2014-01-09 15:01 ` Russell King - ARM Linux
2014-01-10 10:06 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109034940.GA14480@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).