From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register
Date: Tue, 14 Jan 2014 08:04:40 -0600 [thread overview]
Message-ID: <20140114140440.GA15785@saruman.home> (raw)
In-Reply-To: <20140114131052.GA10818@saruman.home>
Hi again,
On Tue, Jan 14, 2014 at 07:10:52AM -0600, Felipe Balbi wrote:
> > diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c
> > index 9f56fb2..194886e 100644
> > --- a/drivers/hwspinlock/omap_hwspinlock.c
> > +++ b/drivers/hwspinlock/omap_hwspinlock.c
> > @@ -101,10 +101,23 @@ static int omap_hwspinlock_probe(struct platform_device *pdev)
> > if (!io_base)
> > return -ENOMEM;
> >
> > + /*
> > + * make sure the module is enabled and clocked before reading
> > + * the module SYSSTATUS register
> > + */
> > + pm_runtime_enable(&pdev->dev);
> > + pm_runtime_get_sync(&pdev->dev);
another thing, you need to check return of pm_runtime_get_sync()
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140114/6ca61f80/attachment.sig>
next prev parent reply other threads:[~2014-01-14 14:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 0:19 [PATCHv4 0/7] omap hwspinlock dt support Suman Anna
2014-01-14 0:19 ` [PATCHv4 1/7] Documentation: dt: add common bindings for hwspinlock Suman Anna
2014-01-14 0:19 ` [PATCHv4 2/7] Documentation: dt: add the omap hwspinlock bindings document Suman Anna
2014-01-14 0:19 ` [PATCHv4 3/7] hwspinlock/core: maintain a list of registered hwspinlock banks Suman Anna
2014-01-14 0:19 ` [PATCHv4 4/7] hwspinlock/core: add common OF helpers Suman Anna
2014-02-07 22:49 ` Bjorn Andersson
2014-02-10 19:14 ` Suman Anna
2014-03-02 5:14 ` Ohad Ben-Cohen
2014-03-02 20:19 ` Bjorn Andersson
2014-03-03 18:46 ` Suman Anna
2014-03-04 17:38 ` Suman Anna
2014-03-13 16:43 ` Josh Cartwright
2014-03-14 8:58 ` Ohad Ben-Cohen
2014-03-14 13:12 ` Ohad Ben-Cohen
2014-03-14 15:23 ` Josh Cartwright
2014-03-15 17:32 ` Ohad Ben-Cohen
2014-09-26 14:40 ` Bjorn Andersson
2014-09-26 16:25 ` Suman Anna
2014-10-06 9:44 ` Ohad Ben-Cohen
2014-11-06 18:24 ` Suman Anna
2014-11-07 5:06 ` Ohad Ben-Cohen
2014-01-14 0:19 ` [PATCHv4 5/7] hwspinlock/omap: add support for dt nodes Suman Anna
2014-01-14 0:19 ` [PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register Suman Anna
2014-01-14 13:10 ` Felipe Balbi
2014-01-14 14:04 ` Felipe Balbi [this message]
2014-01-14 16:56 ` Anna, Suman
2014-01-15 23:46 ` Anna, Suman
2014-01-15 23:36 ` [UPDATED PATCHv4 " Suman Anna
2014-01-14 0:19 ` [PATCHv4 7/7] hwspinlock/omap: enable build for AM33xx, AM43xx & DRA7xx Suman Anna
2014-01-14 13:12 ` Felipe Balbi
2014-01-14 16:51 ` Anna, Suman
2014-01-14 17:29 ` Felipe Balbi
2014-01-14 18:36 ` Anna, Suman
2014-01-14 13:12 ` [PATCHv4 0/7] omap hwspinlock dt support Felipe Balbi
2014-02-10 19:27 ` Suman Anna
2014-02-24 18:14 ` Suman Anna
2014-03-14 20:10 ` Ohad Ben-Cohen
2014-03-14 23:58 ` Suman Anna
2014-03-17 14:23 ` Ohad Ben-Cohen
2014-03-17 19:10 ` Suman Anna
2014-03-17 19:47 ` Ohad Ben-Cohen
2014-03-17 23:46 ` Suman Anna
2014-03-18 13:35 ` Ohad Ben-Cohen
2014-03-31 22:45 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114140440.GA15785@saruman.home \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).