public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH] pinctrl: sunxi: Honor GPIO output initial vaules
Date: Wed, 15 Jan 2014 11:02:41 +0100	[thread overview]
Message-ID: <20140115100241.GI3377@lukather> (raw)
In-Reply-To: <CAGb2v64hs1B=5Ss40AD6K=GTOiYqJrG_vCOxrPzWmjjVgFGvXg@mail.gmail.com>

Hi Chen-Yu,

Nice catch :)

On Wed, Jan 15, 2014 at 04:21:12PM +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> On Wed, Jan 15, 2014 at 8:37 AM, Ma Haijun <mahaijuns@gmail.com> wrote:
> > Hi,
> >
> > I think it is better to set the output value first to avoid glitch.
> 
> If I understand the user manual correctly, setting the output value
> before changing the pin to output function first will have no effect.

I just tested it on my A31, and it is working as expected (the output
value isn't output until the direction is changed).

It would be great if you could test this as well on your device, and
change it like suggested.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140115/b83fc452/attachment.sig>

  reply	other threads:[~2014-01-15 10:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 14:50 [PATCH] pinctrl: sunxi: Honor GPIO output initial vaules Chen-Yu Tsai
     [not found] ` <000001cf1189$fc0f8120$f42e8360$@gmail.com>
2014-01-15  8:21   ` [linux-sunxi] " Chen-Yu Tsai
2014-01-15 10:02     ` Maxime Ripard [this message]
2014-01-15 13:10       ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140115100241.GI3377@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox